Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"React does not recognize the accordionProps prop on a DOM element" #168301

Closed
tsullivan opened this issue Oct 6, 2023 · 8 comments
Closed

"React does not recognize the accordionProps prop on a DOM element" #168301

tsullivan opened this issue Oct 6, 2023 · 8 comments
Assignees
@sebelga
Labels
bug Fixes for quality problems that affect the customer experience EUI Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience)

Comments

@tsullivan
Copy link
Member

Seeing this error in the JS console. It seems to have started with #164910
image

react-dom.development.js:67 Warning: React does not recognize the `accordionProps` prop on a DOM element. If you intentionally want it to appear in the DOM as a custom attribute, spell it as lowercase `accordionprops` instead. If you accidentally passed it from a parent component, remove it from the DOM element.
    at a
    at http://localhost:5602/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:172371:73
    at http://localhost:5602/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:127059:23
    at http://localhost:5602/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:172371:73
    at EuiCollapsibleNavLink (http://localhost:5602/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:81568:19)
    at EuiCollapsibleNavItemDisplay (http://localhost:5602/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:81340:24)
    at EuiCollapsibleNavSubItem (http://localhost:5602/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:81395:28)
    at div
    at http://localhost:5602/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:172371:73
    at div
    at http://localhost:5602/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:172371:73
    at EuiResizeObserver (http://localhost:5602/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:133057:81)
    at div
    at http://localhost:5602/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:172371:73
    at EuiAccordionChildren (http://localhost:5602/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:70799:23)
    at div
    at http://localhost:5602/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:172371:73
    at EuiAccordionClass (http://localhost:5602/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:70603:81)
    at Render (http://localhost:5602/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:167900:17)
    at http://localhost:5602/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:172371:73
    at EuiCollapsibleNavAccordion (http://localhost:5602/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:81145:17)
    at EuiCollapsibleNavItemDisplay (http://localhost:5602/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:81340:24)
    at EuiCollapsibleNavItem (http://localhost:5602/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:81421:25)
    at NavigationSectionUI (http://localhost:5602/9007199254740991/bundles/plugin/serverlessSearch/1.0.0/serverlessSearch.plugin.js:1906:3)
    at NavigationGroupInternalComp (http://localhost:5602/9007199254740991/bundles/plugin/serverlessSearch/1.0.0/serverlessSearch.plugin.js:1672:70)
    at NavigationGroupComp (http://localhost:5602/9007199254740991/bundles/plugin/serverlessSearch/1.0.0/serverlessSearch.plugin.js:1730:13)
    at div
    at div
    at http://localhost:5602/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:172371:73
    at div
    at http://localhost:5602/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:172371:73
    at EuiFlyoutBody (http://localhost:5602/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:109250:23)
    at NavigationUI (http://localhost:5602/9007199254740991/bundles/plugin/serverlessSearch/1.0.0/serverlessSearch.plugin.js:2029:3)
    at Navigation (http://localhost:5602/9007199254740991/bundles/plugin/serverlessSearch/1.0.0/serverlessSearch.plugin.js:1439:3)
    at DefaultNavigation (http://localhost:5602/9007199254740991/bundles/plugin/serverlessSearch/1.0.0/serverlessSearch.plugin.js:2212:3)
    at NavigationKibanaProvider (http://localhost:5602/9007199254740991/bundles/plugin/serverlessSearch/1.0.0/serverlessSearch.plugin.js:1315:3)
    at nav
    at http://localhost:5602/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:172371:73
    at div
    at http://localhost:5602/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:382428:59
    at FocusLockUI (http://localhost:5602/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:378737:71)
    at http://localhost:5602/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:379633:60
    at EuiFocusTrapClass (http://localhost:5602/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:109609:81)
    at EuiFocusTrap (http://localhost:5602/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:109601:126)
    at http://localhost:5602/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:108830:24
    at http://localhost:5602/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:172371:73
    at EuiCollapsibleNavBeta (http://localhost:5602/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:80338:17)
    at http://localhost:5602/9007199254740991/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:172371:73
    at ProjectNavigation (http://localhost:5602/9007199254740991/bundles/core/core.entry.js:13653:3)
@tsullivan tsullivan added the Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) label Oct 6, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/appex-sharedux (Team:SharedUX)

@tsullivan tsullivan added the bug Fixes for quality problems that affect the customer experience label Oct 6, 2023
@vadimkibana vadimkibana added the EUI label Oct 9, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/eui-team (EUI)

@cee-chen
Copy link
Member

cee-chen commented Oct 9, 2023

The above error means accordionProps is being passed to an item without an items array (i.e., isn't an accordion). I can update the underlying EuiCollapsibleNavItem component to ensure it doesn't get spread, but in the interim on the Kibana side of things, you could also add some logic to check whether items exists before passing accordionProps.

@cee-chen cee-chen mentioned this issue Oct 9, 2023
Merged
@cee-chen
Copy link
Member

cee-chen commented Oct 9, 2023

I went ahead and opened an EUI PR for the fix (elastic/eui#7269) - this should get into the next EUI release/upgrade

@tsullivan
Copy link
Member Author

in the interim on the Kibana side of things, you could also add some logic to check whether items exists before passing accordionProps.

Thanks Cee! Your observation makes sense and I think we should keep this issue open until we have that logic on the Kibana side.

@1Copenut
Copy link
Contributor

@tsullivan The fix for this item was included in our EUI release v89.0.0 on Monday. I just merged the Kibana upgrade with this release, so the fix should be in momentarily.

@cee-chen
Copy link
Member

Yep, this should be fixed now in Kibana main @tsullivan, feel free to double check and close this issue if so!

@tsullivan
Copy link
Member Author

Closing per EUI. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sebelga sebelga

Labels
bug Fixes for quality problems that affect the customer experience EUI Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@cee-chen @tsullivan @1Copenut @sebelga @elasticmachine @vadimkibana