Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EuiCollapsibleNavItem] Prevent DOM errors about accordionProps being passed to non-accordions #7269

Merged
merged 1 commit into from
Oct 9, 2023
Merged

[EuiCollapsibleNavItem] Prevent DOM errors about accordionProps being passed to non-accordions #7269

merged 1 commit into from
Oct 9, 2023

Conversation

cee-chen
Copy link
Member

@cee-chen cee-chen commented Oct 9, 2023

Summary

See elastic/kibana#168301

QA

General checklist

N/A, this is a beta component

@cee-chen cee-chen marked this pull request as ready for review October 9, 2023 17:11
@cee-chen cee-chen requested a review from a team as a code owner October 9, 2023 17:11
@cee-chen cee-chen mentioned this pull request Oct 9, 2023
Closed
1Copenut
1Copenut approved these changes Oct 9, 2023
View reviewed changes
Copy link
Contributor

@1Copenut 1Copenut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me!

@1Copenut 1Copenut enabled auto-merge (squash) October 9, 2023 17:24
@kibanamachine
Copy link

Preview staging links for this PR:

@1Copenut 1Copenut merged commit 5b09a18 into elastic:main Oct 9, 2023
10 of 11 checks passed
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

@cee-chen cee-chen deleted the serverless branch October 9, 2023 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1Copenut 1Copenut 1Copenut approved these changes

Assignees
No one assigned
Labels
skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cee-chen @kibanamachine @elasticmachine @1Copenut