-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Security solution] assistantKnowledgeBaseByDefault
flag defaults to true
#198178
Open
stephmilovic
wants to merge
4
commits into
elastic:main
Choose a base branch
from
stephmilovic:kb_flag_true
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+2
−81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephmilovic
added
release_note:skip
Skip the PR/issue when compiling release notes
v9.0.0
Team: SecuritySolution
Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc.
Team:Security Generative AI
Security Generative AI
v8.16.0
backport:version
Backport to applied version labels
v8.17.0
labels
Oct 29, 2024
Pinging @elastic/security-solution (Team: SecuritySolution) |
This was referenced Oct 29, 2024
@elasticmachine merge upstream |
@elasticmachine merge upstream |
patrykkopycinski
approved these changes
Oct 30, 2024
andrew-goldstein
approved these changes
Oct 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @stephmilovic!
✅ Desk tested locally
LGTM 🚀
⏳ Build in-progress, with failures
Failed CI StepsTest Failures
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport:version
Backport to applied version labels
release_note:skip
Skip the PR/issue when compiling release notes
Team:Security Generative AI
Security Generative AI
Team: SecuritySolution
Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc.
v8.16.0
v8.17.0
v9.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Updates the
assistantKnowledgeBaseByDefault
flag defaults totrue
, enabling the flag by default with no ability to turn it off besides reverting this PR.This PR will be backported to
8.16
,8.x
andmain
, but it is intended to live in 8.16 only . This PR will be followed up by a PR to remove the feature flag and all of its code paths, but that PR will only be backported to8.x
andmain
in order to not risk many code changes in8.16
.PR merge order
[Security solution] Knowledge base tour video updatemerged![Security Assistant] Knowledge base switch to use semantic_text)merged![Security AI Assistant] Fixed license issue for Knowledge Base resources initializationmerged!assistantKnowledgeBaseByDefault
flag defaults to true (THIS PR)assistantKnowledgeBaseByDefault
flag removed