Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security solution] assistantKnowledgeBaseByDefault flag defaults to true #198178

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

stephmilovic
Copy link
Contributor

@stephmilovic stephmilovic commented Oct 29, 2024

Summary

Updates the assistantKnowledgeBaseByDefault flag defaults to true, enabling the flag by default with no ability to turn it off besides reverting this PR.

This PR will be backported to 8.16, 8.x and main, but it is intended to live in 8.16 only . This PR will be followed up by a PR to remove the feature flag and all of its code paths, but that PR will only be backported to8.x and main in order to not risk many code changes in 8.16.

PR merge order

  1. [Security solution] Knowledge base tour video update merged!
  2. [Security Assistant] Knowledge base switch to use semantic_text) merged!
  3. [Security AI Assistant] Fixed license issue for Knowledge Base resources initialization merged!
  4. [Security solution] assistantKnowledgeBaseByDefault flag defaults to true (THIS PR)
  5. [Security solution] assistantKnowledgeBaseByDefault flag removed

@stephmilovic stephmilovic added release_note:skip Skip the PR/issue when compiling release notes v9.0.0 Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Security Generative AI Security Generative AI v8.16.0 backport:version Backport to applied version labels v8.17.0 labels Oct 29, 2024
@stephmilovic stephmilovic requested review from a team as code owners October 29, 2024 17:52
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@stephmilovic
Copy link
Contributor Author

@elasticmachine merge upstream

@elastic elastic deleted a comment from elasticmachine Oct 30, 2024
@stephmilovic
Copy link
Contributor Author

@elasticmachine merge upstream

Copy link
Contributor

@andrew-goldstein andrew-goldstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @stephmilovic!
✅ Desk tested locally
LGTM 🚀

@elasticmachine
Copy link
Contributor

⏳ Build in-progress, with failures

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #88 / GenAI - Knowledge Base Entries APIs @ess Basic Security AI Assistant Knowledge Base Entries "before all" hook in "@ess Basic Security AI Assistant Knowledge Base Entries"
  • [job] [logs] FTR Configs #88 / GenAI - Knowledge Base Entries APIs @ess Basic Security AI Assistant Knowledge Base Entries "before all" hook in "@ess Basic Security AI Assistant Knowledge Base Entries"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:version Backport to applied version labels release_note:skip Skip the PR/issue when compiling release notes Team:Security Generative AI Security Generative AI Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.16.0 v8.17.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants