-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Security solution] assistantKnowledgeBaseByDefault
flag removed
#198180
Draft
stephmilovic
wants to merge
11
commits into
elastic:main
Choose a base branch
from
stephmilovic:kb_flag_remove
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+202
−2,779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephmilovic
added
release_note:skip
Skip the PR/issue when compiling release notes
v9.0.0
Team: SecuritySolution
Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc.
Team:Security Generative AI
Security Generative AI
backport:version
Backport to applied version labels
v8.17.0
labels
Oct 29, 2024
🤖 Jobs for this PR can be triggered through checkboxes. 🚧
ℹ️ To trigger the CI, please tick the checkbox below 👇
|
💔 Build Failed
Failed CI Steps
Test Failures
Metrics [docs]Async chunks
Page load bundle
History |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport:version
Backport to applied version labels
release_note:skip
Skip the PR/issue when compiling release notes
Team:Security Generative AI
Security Generative AI
Team: SecuritySolution
Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc.
v8.17.0
v9.0.0
WIP
Work in progress
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Still WIP
Removes the
assistantKnowledgeBaseByDefault
flag and all of its code paths.This PR will be backported to
8.x
andmain
. In order to not risk many code changes in8.16
and enable us to rollback,8.16
will simply have a hardcodedassistantKnowledgeBaseByDefault
value of true. That is implemented in #198178, which needs to merge before this PR.Since #198178 will set
assistantKnowledgeBaseByDefault
to true by default, this PR is not the one that enables the flag by default. This simply cleans up all the code paths that are no longer used.PR merge order
[Security solution] Knowledge base tour video updatemerged!assistantKnowledgeBaseByDefault
flag defaults to trueassistantKnowledgeBaseByDefault
flag removed (THIS PR)