[Screenshotting] PoC print media #126913
Closed
[Screenshotting] PoC print media #126913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jloleysens
added
(Deprecated) Feature:Reporting
jloleysens
commented
Mar 4, 2022
Comment on lines
+39
to
+55
| const mediaAwareStyleLoaders = [ | ||
| { | ||
| resourceQuery: /print/, | ||
| loader: 'style-loader', | ||
| options: { | ||
| attributes: { 'data-print-media-style': 'true' }, | ||
| }, | ||
| }, | ||
| { | ||
| resourceQuery: undefined, | ||
| loader: 'style-loader', | ||
| options: { | ||
| attributes: { media: 'screen, projection' }, | ||
| }, | ||
| }, | ||
| ]; | ||
|
|
There was a problem hiding this comment.
The version of style-loader we are using has a known bug for setting the media attribute on style tags webpack-contrib/style-loader#458
There was a problem hiding this comment.
This is a work-around that instead uses the MutationObserver hacked into core for updating media attributes based on the presence of the data-print-media-style. The result of this is the print styles "flash" once as they are applied by the browser until the MutationObserver kicks in. Very hacky, but work-around for rather not updating style-loader + webpack to latest version.
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
💔 Build FailedFailed CI StepsTest Failures
Metrics [docs]Module Count
Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Demonstration (focussing on the
dashboardplugin) of how we might leverage browser printing functionality for creating PNG or PDF reports. This will enable users to print certain pages of Kibana in their browser rather than requesting a report from the Kibana server.If this work succeeds it may have far-reaching implications:
pdfmake, and instead utilise existing browser functionaliyWith this PoC we want to establish that we can:
preserve-layoutstyle reports (PDF & PNG)print-optimizedstyle reports (PDF only)canvas, multi-page style reports (PDF only)Rest of the description TODO
Checklist
Delete any items that are not applicable to this PR.
Risk Matrix
Delete this section if it is not applicable to this PR.
Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.
When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:
For maintainers