Deprecate Anonymous Authentication Credentials #131636
Merged
+378
−63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeramysoucy
added
release_note:deprecation
Team:Security
jeramysoucy
force-pushed
the
kibana-deprecate-anon-users
branch
5 times, most recently
from
ef45ada
to
e33ea95
Compare
jeramysoucy
changed the title
jeramysoucy
changed the title
… credentials of anonymous authentication providers. Adds telemetry for usage of anonymous authentication credential type.
jeramysoucy
force-pushed
the
kibana-deprecate-anon-users
branch
from
24638de
to
9cdb5c3
Compare
|
Pinging @elastic/kibana-security (Team:Security) |
lukeelmers
approved these changes
May 10, 2022
|
@elasticmachine merge upstream |
jportner
reviewed
May 18, 2022
There was a problem hiding this comment.
Nice job on this, and I appreciate the tests!
A few nits below. In addition, we need to update the Anonymous Authentication docs at docs/user/security/authentication/index.asciidoc, can you tackle that too?
Co-authored-by: Joe Portner <[email protected]>
Co-authored-by: Joe Portner <[email protected]>
Co-authored-by: Joe Portner <[email protected]>
…ink logic and typos. Please enter the commit message for your changes. Lines starting
|
Completed nits and doc link logic fix. |
|
@elasticmachine merge upstream |
jportner
approved these changes
May 18, 2022
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #128877
Overview
This PR adds deprecation warnings for 2 credential types of anonymous authentication providers:
Any configured anonymous authentication providers with either of these credentials will trigger a depreciation warning, even if the provider is not enabled.
This PR also adds usage telemetry for the credential type of the enabled anonymous authentication provider, defined as anonymousCredentialType, with the following possible values:
Testing
Notes
A decision was made to include disabled anonymous authentication providers in the deprecation check. Usage telemetry is only concerned with the enabled anonymous authentication provider.