[Discover] Suppress "Missing index" toasts

src/plugins/data_views/common/data_views/data_views.test.ts

@@ -420,7 +420,7 @@ describe('IndexPatterns', () => {
   describe('getDefaultDataView', () => {
     beforeEach(() => {
       indexPatterns.clearCache();
-      jest.resetAllMocks();
+      jest.clearAllMocks();
     });
 
     test('gets default data view', async () => {
@@ -434,6 +434,27 @@ describe('IndexPatterns', () => {
       expect(savedObjectsClient.find).toBeCalledTimes(1);
     });
 
+    test('gets default data view and passes down correct arguments (refreshFields and displayErrors)', async () => {
+      uiSettings.get = jest.fn().mockResolvedValue(indexPatternObj.id);
+      savedObjectsClient.get = jest.fn().mockResolvedValue(indexPatternObj);
+      savedObjectsClient.find = jest.fn().mockResolvedValue([indexPatternObj]);
+      jest.spyOn(indexPatterns, 'get');
+      jest.spyOn(indexPatterns, 'refreshFields');
+
+      const dataView = await indexPatterns.get(indexPatternObj.id); // and to cache the result
+
+      const refreshFields = true;
+      const displayErrors = false;
+      expect(await indexPatterns.getDefaultDataView(refreshFields, displayErrors)).toBeInstanceOf(
+        DataView
+      );
+      expect(savedObjectsClient.get).toBeCalledTimes(1);
+      expect(savedObjectsClient.find).toBeCalledTimes(1);
+
+      expect(indexPatterns.get).toBeCalledWith(indexPatternObj.id, displayErrors, refreshFields);
+      expect(indexPatterns.refreshFields).toBeCalledWith(dataView, displayErrors);
+    });
+
     test('returns undefined if no data views exist', async () => {
       uiSettings.get = jest.fn().mockResolvedValue('foo');
       savedObjectsClient.find = jest.fn().mockResolvedValue([]);
@@ -487,6 +508,7 @@ describe('IndexPatterns', () => {
     });
 
     test('dont set defaultIndex without capability allowing advancedSettings save', async () => {
+      uiSettings.get = jest.fn().mockResolvedValue(null);
       savedObjectsClient.find = jest.fn().mockResolvedValue([
         {
           id: 'id1',

src/plugins/data_views/common/data_views/data_views.ts

@@ -215,8 +215,12 @@ export interface DataViewsServicePublicMethods {
   /**
    * Get default data view, if it doesn't exist, choose and save new default data view and return it.
    * @param refreshFields - refresh field list when true
+   * @param displayErrors - If set false, API consumer is responsible for displaying and handling errors.
    */
-  getDefaultDataView: (refreshFields?: boolean) => Promise<DataView | null>;
+  getDefaultDataView: (
+    refreshFields?: boolean,
+    displayErrors?: boolean
+  ) => Promise<DataView | null>;
   /**
    * Get fields for data view
    * @param dataView - Data view instance or spec
@@ -261,7 +265,10 @@ export interface DataViewsServicePublicMethods {
    * @params savedObject - Data view saved object
    * @params displayErrors - If set false, API consumer is responsible for displaying and handling errors.
    */
-  savedObjectToSpec: (savedObject: SavedObject<DataViewAttributes>) => DataViewSpec;
+  savedObjectToSpec: (
+    savedObject: SavedObject<DataViewAttributes>,
+    displayErrors?: boolean
+  ) => DataViewSpec;
   /**
    * Set default data view.
    * @param id - Id of the data view to set as default.
@@ -570,30 +577,28 @@ export class DataViewsService {
    * @param displayErrors  - If set false, API consumer is responsible for displaying and handling errors.
    */
   refreshFields = async (dataView: DataView, displayErrors: boolean = true) => {
-    if (!displayErrors) {
-      return this.refreshFieldsFn(dataView);
-    }
-
     try {
       await this.refreshFieldsFn(dataView);
     } catch (err) {
-      if (err instanceof DataViewMissingIndices) {
-        this.onNotification(
-          { title: err.message, color: 'danger', iconType: 'alert' },
-          `refreshFields:${dataView.getIndexPattern()}`
+      if (displayErrors) {
+        if (err instanceof DataViewMissingIndices) {
+          this.onNotification(
+            { title: err.message, color: 'danger', iconType: 'alert' },
+            `refreshFields:${dataView.getIndexPattern()}`
+          );
+        }
+
+        this.onError(
+          err,
+          {
+            title: i18n.translate('dataViews.fetchFieldErrorTitle', {
+              defaultMessage: 'Error fetching fields for data view {title} (ID: {id})',
+              values: { id: dataView.id, title: dataView.getIndexPattern() },
+            }),
+          },
+          dataView.getIndexPattern()
         );
       }
-
-      this.onError(
-        err,
-        {
-          title: i18n.translate('dataViews.fetchFieldErrorTitle', {
-            defaultMessage: 'Error fetching fields for data view {title} (ID: {id})',
-            values: { id: dataView.id, title: dataView.getIndexPattern() },
-          }),
-        },
-        dataView.getIndexPattern()
-      );
     }
   };
 
@@ -610,7 +615,8 @@ export class DataViewsService {
     id: string,
     title: string,
     options: GetFieldsOptions,
-    fieldAttrs: FieldAttrs = {}
+    fieldAttrs: FieldAttrs = {},
+    displayErrors: boolean = true
   ) => {
     const fieldsAsArr = Object.values(fields);
     const scriptedFields = fieldsAsArr.filter((field) => field.scripted);
@@ -630,10 +636,12 @@ export class DataViewsService {
       return { fields: this.fieldArrayToMap(updatedFieldList, fieldAttrs), indices };
     } catch (err) {
       if (err instanceof DataViewMissingIndices) {
-        this.onNotification(
-          { title: err.message, color: 'danger', iconType: 'alert' },
-          `refreshFieldSpecMap:${title}`
-        );
+        if (displayErrors) {
+          this.onNotification(
+            { title: err.message, color: 'danger', iconType: 'alert' },
+            `refreshFieldSpecMap:${title}`
+          );
+        }
         return {};
       }
 
@@ -739,9 +747,11 @@ export class DataViewsService {
   private initFromSavedObjectLoadFields = async ({
     savedObjectId,
     spec,
+    displayErrors = true,
   }: {
     savedObjectId: string;
     spec: DataViewSpec;
+    displayErrors?: boolean;
   }) => {
     const { title, type, typeMeta, runtimeFieldMap } = spec;
     const { fields, indices } = await this.refreshFieldSpecMap(
@@ -755,7 +765,8 @@ export class DataViewsService {
         rollupIndex: typeMeta?.params?.rollup_index,
         allowNoIndex: spec.allowNoIndex,
       },
-      spec.fieldAttrs
+      spec.fieldAttrs,
+      displayErrors
     );
 
     const runtimeFieldSpecs = this.getRuntimeFields(runtimeFieldMap, spec.fieldAttrs);
@@ -779,6 +790,7 @@ export class DataViewsService {
       const fieldsAndIndices = await this.initFromSavedObjectLoadFields({
         savedObjectId: savedObject.id,
         spec,
+        displayErrors,
       });
       fields = fieldsAndIndices.fields;
       indices = fieldsAndIndices.indices;
@@ -883,7 +895,7 @@ export class DataViewsService {
   ): Promise<DataView> => {
     const dataViewFromCache = this.dataViewCache.get(id)?.then(async (dataView) => {
       if (dataView && refreshFields) {
-        await this.refreshFields(dataView);
+        await this.refreshFields(dataView, displayErrors);
       }
       return dataView;
     });
@@ -1145,9 +1157,13 @@ export class DataViewsService {
    * If no possible data view found to become a default returns null.
    *
    * @param {boolean} refreshFields - if true, will refresh the fields of the default data view
+   * @param {boolean} displayErrors - If set false, API consumer is responsible for displaying and handling errors.
    * @returns default data view
    */
-  async getDefaultDataView(refreshFields?: boolean): Promise<DataView | null> {
+  async getDefaultDataView(
+    refreshFields?: boolean,
+    displayErrors: boolean = true
+  ): Promise<DataView | null> {
     const patterns = await this.getIdsWithTitle();
     let defaultId: string | undefined = await this.config.get('defaultIndex');
     const exists = defaultId ? patterns.some((pattern) => pattern.id === defaultId) : false;
@@ -1168,7 +1184,7 @@ export class DataViewsService {
     }
 
     if (defaultId) {
-      return this.get(defaultId, undefined, refreshFields);
+      return this.get(defaultId, displayErrors, refreshFields);
     } else {
       return null;
     }

src/plugins/discover/public/application/main/components/no_results/no_results.test.tsx

@@ -12,6 +12,8 @@ import { findTestSubject } from '@elastic/eui/lib/test';
 
 import { DiscoverNoResults, DiscoverNoResultsProps } from './no_results';
 import { KibanaContextProvider } from '@kbn/kibana-react-plugin/public';
+import { getDiscoverStateMock } from '../../../../__mocks__/discover_state.mock';
+import { DiscoverMainProvider } from '../../services/discover_state_provider';
 
 beforeEach(() => {
   jest.clearAllMocks();
@@ -27,9 +29,12 @@ function mountAndFindSubjects(props: Omit<DiscoverNoResultsProps, 'onDisableFilt
       },
     },
   };
+  const stateContainer = getDiscoverStateMock({ isTimeBased: true });
   const component = mountWithIntl(
     <KibanaContextProvider services={services}>
-      <DiscoverNoResults onDisableFilters={() => {}} {...props} />
+      <DiscoverMainProvider value={stateContainer}>
+        <DiscoverNoResults onDisableFilters={() => {}} {...props} />
+      </DiscoverMainProvider>
     </KibanaContextProvider>
   );
   return {

src/plugins/discover/public/application/main/components/no_results/no_results_suggestions/no_results_suggestion_default.tsx

@@ -8,16 +8,29 @@
 
 import React from 'react';
 import { FormattedMessage } from '@kbn/i18n-react';
-import { EuiDescriptionList, EuiDescriptionListDescription } from '@elastic/eui';
+import { EuiDescriptionList, EuiDescriptionListDescription, EuiCode } from '@elastic/eui';
+import { useInternalStateSelector } from '../../../services/discover_internal_state_container';
 
 export function NoResultsSuggestionDefault() {
+  const dataViewPattern = useInternalStateSelector((state) => state.dataView?.getIndexPattern?.());
+
   return (
     <EuiDescriptionList compressed>
       <EuiDescriptionListDescription data-test-subj="discoverNoResultsCheckIndices">
-        <FormattedMessage
-          id="discover.noResults.noDocumentsOrCheckPermissionsDescription"
-          defaultMessage="Make sure you have permission to view the indices and that they contain documents."
-        />
+        {dataViewPattern ? (
+          <FormattedMessage
+            id="discover.noResults.noDocumentsOrCheckIndicesAndPermissionsDescription"
+            defaultMessage="Make sure the indices matching {dataViewPattern} exist, that you have permission to view them and that they contain documents."
+            values={{
+              dataViewPattern: <EuiCode>{dataViewPattern}</EuiCode>,
+            }}
+          />
+        ) : (
+          <FormattedMessage
+            id="discover.noResults.noDocumentsOrCheckPermissionsDescription"
+            defaultMessage="Make sure you have permission to view the indices and that they contain documents."
+          />
+        )}
       </EuiDescriptionListDescription>
     </EuiDescriptionList>
   );

src/plugins/discover/public/application/main/discover_main_route.tsx

@@ -100,7 +100,7 @@ export function DiscoverMainRoute(props: Props) {
           return;
         }
 
-        const defaultDataView = await data.dataViews.getDefaultDataView();
+        const defaultDataView = await data.dataViews.getDefaultDataView(false, false);
 
         if (!defaultDataView) {
           setShowNoDataPage(true);

src/plugins/discover/public/application/main/hooks/use_discover_state.ts

@@ -218,7 +218,7 @@ export function useDiscoverState({
    */
   const onChangeDataView = useCallback(
     async (id: string) => {
-      const nextDataView = await dataViews.get(id);
+      const nextDataView = await dataViews.get(id, false);
       if (nextDataView && dataView) {
         const nextAppState = getDataViewAppState(
           dataView,

src/plugins/discover/public/application/main/utils/resolve_data_view.ts

@@ -67,7 +67,7 @@ export async function loadDataView(
   let fetchedDataView: DataView | undefined;
   // try to fetch adhoc data view first
   try {
-    fetchedDataView = fetchId ? await dataViews.get(fetchId) : undefined;
+    fetchedDataView = fetchId ? await dataViews.get(fetchId, false) : undefined;
     if (fetchedDataView && !fetchedDataView.isPersisted()) {
       return {
         list: dataViewList || [],
@@ -88,7 +88,7 @@ export async function loadDataView(
     loaded: fetchedDataView
       ? fetchedDataView
       : // we can be certain that the data view exists due to an earlier hasData check
-        ((await dataViews.getDefaultDataView()) as DataView),
+        ((await dataViews.getDefaultDataView(false, false)) as DataView),
     stateVal: fetchId,
     stateValFound: !!fetchId && !!fetchedDataView,
   };

src/plugins/unified_field_list/public/hooks/use_existing_fields.ts

@@ -106,7 +106,7 @@ export const useExistingFieldsFetcher = (
       }
 
       const numberOfFetches = (currentInfo?.numberOfFetches ?? 0) + 1;
-      const dataView = await dataViews.get(dataViewId);
+      const dataView = await dataViews.get(dataViewId, false);
 
       if (!dataView?.title) {
         return;
@@ -155,8 +155,6 @@ export const useExistingFieldsFetcher = (
           info.existingFieldsByFieldNameMap = booleanMap(existingFieldNames);
           info.fetchStatus = ExistenceFetchStatus.succeeded;
         } catch (error) {
-          // eslint-disable-next-line no-console
-          console.error(error);
           info.fetchStatus = ExistenceFetchStatus.failed;
         }
       }

src/plugins/unified_field_list/public/hooks/use_grouped_fields.ts

@@ -88,7 +88,7 @@ export function useGroupedFields<T extends FieldListItem = DataViewField>({
   useEffect(() => {
     const getDataView = async () => {
       if (dataViewId) {
-        setDataView(await services.dataViews.get(dataViewId));
+        setDataView(await services.dataViews.get(dataViewId, false));
       }
     };
     getDataView();

src/plugins/unified_search/public/dataview_picker/change_dataview.tsx

@@ -304,7 +304,7 @@ export function ChangeDataView({
           setPopoverIsOpen={setPopoverIsOpen}
           onChangeDataView={async (newId) => {
             // refreshing the field list
-            await dataViews.get(newId, undefined, true);
+            await dataViews.get(newId, false, true);
             setSelectedDataViewId(newId);
             setPopoverIsOpen(false);
             if (isTextBasedLangSelected && !isTextLangTransitionModalDismissed) {
@@ -355,6 +355,7 @@ export function ChangeDataView({
           </EuiFlexItem>
         </EuiFlexGroup>,
         <TextBasedLanguagesList
+          key="text-based-languages-list"
           textBasedLanguages={textBasedLanguages}
           selectedOption={triggerLabel}
           onChange={(lang) => {