Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[i18n][system upgrade] Upgrade i18n tooling #186519

Merged
merged 25 commits into from
Jul 16, 2024
Merged

[i18n][system upgrade] Upgrade i18n tooling #186519

merged 25 commits into from
Jul 16, 2024

Conversation

Bamieh
Copy link
Member

@Bamieh Bamieh commented Jun 20, 2024 •
edited by stratoula
Loading

Update i18n tools after the main packages upgrade. This upgrade makes use of formatJS tooling instead of fully implementing the parsers ourselves. It also changes our custom AST parsing from babel to the typescript compiler.

  • i18n exrtract
  • i18n check
  • i18n integrate
  • add test cases for formatjs runner
  • Make sure all CLI flags are handled properly
  • Update tooling readme

Closes #180616
Closes #187703

Note to reviewers

Teams outside operations and core are probably requested to review because the i18n_check fixed malformed i18n messages in your plugins. Please check and approve :elasticheart:

@Bamieh Bamieh added backport:skip This commit does not require backporting 8.16 candidate labels Jun 20, 2024
@Bamieh Bamieh marked this pull request as ready for review July 4, 2024 15:38
@Bamieh Bamieh requested review from a team as code owners July 4, 2024 15:38
@Bamieh Bamieh requested a review from nikitaindik July 4, 2024 15:39
@Bamieh Bamieh added the release_note:skip Skip the PR/issue when compiling release notes label Jul 4, 2024
@botelastic botelastic bot added the ci:project-deploy-observability Create an Observability project label Jul 4, 2024
afharo
afharo approved these changes Jul 5, 2024
View reviewed changes
Copy link
Member

@afharo afharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I missed the files in src/dev/i18n_tools since they are owned by Operations. Should we change the CODEOWNERS?

src/dev/i18n_tools/__fixtures__/extraction_signatures/unused_value.ts Show resolved Hide resolved
@stratoula stratoula mentioned this pull request Jul 8, 2024
Closed
justinkambic
justinkambic approved these changes Jul 8, 2024
View reviewed changes
Copy link
Contributor

@justinkambic justinkambic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

APM change LGTM

@Bamieh Bamieh requested review from criamico and Ikuni17 July 15, 2024 12:56
@Bamieh
Copy link
Member Author

Bamieh commented Jul 15, 2024

@elasticmachine merge upstream

@elasticmachine
Copy link
Contributor

merge conflict between base and head

criamico
criamico approved these changes Jul 16, 2024
View reviewed changes
Copy link
Contributor

@criamico criamico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fleet LGTM

@Bamieh Bamieh enabled auto-merge (squash) July 16, 2024 18:12
@elasticmachine
Copy link
Contributor

elasticmachine commented Jul 16, 2024 •
edited
Loading

⏳ Build in-progress

Failed CI Steps

History

@Bamieh Bamieh merged commit 7c6aa3f into elastic:main Jul 16, 2024
50 checks passed
@Bamieh Bamieh deleted the i18n/tooling_update branch July 17, 2024 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsullivan tsullivan tsullivan approved these changes

@sabarasaba sabarasaba sabarasaba approved these changes

@afharo afharo afharo approved these changes

@Ikuni17 Ikuni17 Ikuni17 approved these changes

@ThomThomson ThomThomson ThomThomson approved these changes

@nikitaindik nikitaindik nikitaindik approved these changes

@criamico criamico criamico approved these changes

@stratoula stratoula stratoula approved these changes

@justinkambic justinkambic justinkambic approved these changes

@juliaElastic juliaElastic juliaElastic approved these changes

Assignees
No one assigned
Labels
8.16 candidate apm:review backport:skip This commit does not require backporting ci:project-deploy-observability Create an Observability project release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team v8.16.0
Projects
None yet
Milestone
No milestone