-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[i18n][system upgrade] Upgrade i18n tooling #186519
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I missed the files in src/dev/i18n_tools
since they are owned by Operations. Should we change the CODEOWNERS?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
APM change LGTM
src/dev/i18n_tools/__fixtures__/extraction_signatures/malformed_icu.ts
Outdated
Show resolved
Hide resolved
src/dev/i18n_tools/tasks/validate_translation_files/remove_outdated_translations.ts
Show resolved
Hide resolved
...pplications/integrations/sections/epm/screens/detail/assets/install_kibana_assets_button.tsx
Outdated
Show resolved
Hide resolved
@elasticmachine merge upstream |
merge conflict between base and head |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fleet LGTM
⏳ Build in-progress
Failed CI StepsHistory
|
Update i18n tools after the main packages upgrade. This upgrade makes use of formatJS tooling instead of fully implementing the parsers ourselves. It also changes our custom AST parsing from babel to the typescript compiler.
Closes #180616
Closes #187703
Note to reviewers
Teams outside operations and core are probably requested to review because the
i18n_check
fixed malformed i18n messages in your plugins. Please check and approve :elasticheart: