-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Discover] Fix Field Statistics when discover:searchFieldsFromSource is enabled #187250
Merged
jughosta
merged 8 commits into
elastic:main
from
jughosta:187241-fix-statistics-with-source
Jul 11, 2024
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
a5175a4
[Discover] Fix Field Statistics when discover:searchFieldsFromSource …
jughosta 81d61ba
[Discover] Add tests
jughosta 6e6bf31
Merge branch 'main' into 187241-fix-statistics-with-source
jughosta 01c3c20
Merge branch 'main' into 187241-fix-statistics-with-source
jughosta d3294e1
Merge branch 'main' into 187241-fix-statistics-with-source
jughosta 07bdf4f
Merge branch 'main' into 187241-fix-statistics-with-source
kertal bc914e7
Merge branch 'main' into 187241-fix-statistics-with-source
jughosta 37b5cbe
[Discover] Add a comment
jughosta File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
72 changes: 72 additions & 0 deletions
72
test/functional/apps/discover/group6/_field_stats_table.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,72 @@ | ||
/* | ||
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
* or more contributor license agreements. Licensed under the Elastic License | ||
* 2.0 and the Server Side Public License, v 1; you may not use this file except | ||
* in compliance with, at your election, the Elastic License 2.0 or the Server | ||
* Side Public License, v 1. | ||
*/ | ||
|
||
import { FtrProviderContext } from '../ftr_provider_context'; | ||
|
||
export default function ({ getService, getPageObjects }: FtrProviderContext) { | ||
const PageObjects = getPageObjects(['common', 'discover', 'timePicker', 'header']); | ||
const esArchiver = getService('esArchiver'); | ||
const testSubjects = getService('testSubjects'); | ||
const kibanaServer = getService('kibanaServer'); | ||
const security = getService('security'); | ||
const defaultSettings = { | ||
defaultIndex: 'logstash-*', | ||
}; | ||
|
||
describe('discover field statistics table', function () { | ||
before(async () => { | ||
await security.testUser.setRoles(['kibana_admin', 'test_logstash_reader']); | ||
await esArchiver.loadIfNeeded('test/functional/fixtures/es_archiver/logstash_functional'); | ||
await kibanaServer.importExport.load('test/functional/fixtures/kbn_archiver/discover'); | ||
}); | ||
|
||
after(async () => { | ||
await kibanaServer.importExport.unload('test/functional/fixtures/kbn_archiver/discover'); | ||
await esArchiver.unload('test/functional/fixtures/es_archiver/logstash_functional'); | ||
await kibanaServer.savedObjects.cleanStandardList(); | ||
}); | ||
|
||
[true, false].forEach((shouldSearchFieldsFromSource) => { | ||
describe(`discover:searchFieldsFromSource: ${shouldSearchFieldsFromSource}`, function () { | ||
before(async function () { | ||
await PageObjects.timePicker.setDefaultAbsoluteRangeViaUiSettings(); | ||
await kibanaServer.uiSettings.update({ | ||
...defaultSettings, | ||
'discover:searchFieldsFromSource': shouldSearchFieldsFromSource, | ||
}); | ||
await PageObjects.common.navigateToApp('discover'); | ||
await PageObjects.header.waitUntilLoadingHasFinished(); | ||
await PageObjects.discover.waitUntilSearchingHasFinished(); | ||
}); | ||
|
||
after(async () => { | ||
await kibanaServer.uiSettings.replace({}); | ||
}); | ||
|
||
it('should show Field Statistics data in data view mode', async () => { | ||
await testSubjects.click('dscViewModeFieldStatsButton'); | ||
await PageObjects.header.waitUntilLoadingHasFinished(); | ||
await testSubjects.existOrFail('dataVisualizerTableContainer'); | ||
|
||
await testSubjects.click('dscViewModeDocumentButton'); | ||
await PageObjects.header.waitUntilLoadingHasFinished(); | ||
await testSubjects.existOrFail('discoverDocTable'); | ||
}); | ||
|
||
it('should show Field Statistics data in ES|QL mode', async () => { | ||
await PageObjects.discover.selectTextBaseLang(); | ||
await PageObjects.discover.waitUntilSearchingHasFinished(); | ||
|
||
await testSubjects.click('dscViewModeFieldStatsButton'); | ||
await PageObjects.header.waitUntilLoadingHasFinished(); | ||
await testSubjects.existOrFail('dataVisualizerTableContainer'); | ||
}); | ||
}); | ||
}); | ||
}); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you mind adding a comment here explaining why we're filtering out
_source
(similar to the one above)?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, thanks for the review!