-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Search][Playground] Update UI #187608
Merged
Merged
[Search][Playground] Update UI #187608
Changes from 25 commits
Commits
Show all changes
31 commits
Select commit
Hold shift + click to select a range
3470850
Update setup page
yansavitski a8b9cdf
Set playground template panelled and move header to plugin
yansavitski b02bd89
Update header sizes
yansavitski bdcd5d1
Update input actions space
yansavitski c634ead
Add create index button in setup page
yansavitski 3bf7f93
Update sidebar
yansavitski 0e1b338
Add data action button
yansavitski a861d24
Update chat sidebar
yansavitski df9525b
Update query mode and fix bugs
yansavitski f2b2fc2
Add callout for empty index
yansavitski 6f7af76
Fix add indices in query mode
yansavitski e436ca6
Update query fields after adding new index
yansavitski d34b330
Merge branch 'main' of github.com:elastic/kibana into playground-ui-u…
yansavitski 270a2ae
Fix source fields update after merge
yansavitski 5a97b53
Update ftr for ess
yansavitski 3425998
Fix es3 ftr tests
yansavitski 07118b7
Fix pr checks
yansavitski 74b6ffd
Merge branch 'main' of github.com:elastic/kibana into playground-ui-u…
yansavitski e9dc061
Update message list color
yansavitski e03e152
Update transform function
yansavitski 1dbc4a1
Use merge fields
yansavitski 5b4a3e1
Merge branch 'main' of github.com:elastic/kibana into playground-ui-u…
yansavitski 5dd043f
Fix check types
yansavitski d3f6008
Revert "Update transform function"
yansavitski b441061
fix issue with indices not existing
joemcelroy d3d65f2
FIx reset query after goes to chat mode
yansavitski 0c6d783
Add callout for no source fields
yansavitski 51fe5ef
Update index flyout tests
yansavitski aa28fbb
Fix using old version of addIndex function in useEffect
yansavitski 9a67631
Update page template for serverless
yansavitski 0630948
Move header docs to the left
yansavitski File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not put the QueryClient as part of the PlaygroundProvider?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I moved it here to use useSourceFields hook in the playground provider, to avoid bugs when the hook is unmounted and the index is changed. This hook used queryClient so I moved it to the parent component. But then I figured out that it affected a lot more and needed extra time to fix some bugs so I returned changes. I forgot to return this one as well. I can revert these changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I forgot that i've added a load connectors hook in playground provider, so query client provider needs to be defined in upper component
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you think it still could be incapsulated in the PlaygroundProvider still? just the PlaygroundProvider is two components, for the hook and the queryClientProvider?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if its not possible, i would just create a new provider component for QueryClient thats in our providers folder vs making the QueryClient instantiation in a util.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can add queryClientProvide in PlaygroundProvide, but in that case need to find another place to load connector and set models