Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM] Unskip APM alerting tests #188006

Merged
merged 2 commits into from
Jul 11, 2024
Merged

[APM] Unskip APM alerting tests #188006

merged 2 commits into from
Jul 11, 2024

Conversation

crespocarlos
Copy link
Contributor

@crespocarlos crespocarlos commented Jul 10, 2024 •
edited by kibanamachine
Loading

fixes #176948
fixes #177061
fixes #177104

Summary

I managed to reproduce the problem when error_grouping_key was null. It was probably fixed here #184642

https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/6512

@obltmachine
Copy link

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@crespocarlos crespocarlos force-pushed the 176948-fix-error_count_threshold-test branch from 087451b to d6c0456 Compare July 10, 2024 16:00
@crespocarlos
Copy link
Contributor Author

/ci

@crespocarlos crespocarlos changed the title [APM] Unskip error_count_threshold test [APM] Unskip APM alerting tests Jul 10, 2024
@kibanamachine
Copy link
Contributor

Flaky Test Runner Stats

🎉 All tests passed! - kibana-flaky-test-suite-runner#6512

[✅] x-pack/test/apm_api_integration/basic/config.ts: 50/50 tests passed.

see run history

@crespocarlos crespocarlos marked this pull request as ready for review July 11, 2024 06:01
@crespocarlos crespocarlos requested a review from a team as a code owner July 11, 2024 06:01
@crespocarlos crespocarlos added release_note:skip Skip the PR/issue when compiling release notes backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team v8.16.0 labels Jul 11, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

@crespocarlos
Copy link
Contributor Author

@elasticmachine merge upstream

@botelastic botelastic bot added the ci:project-deploy-observability Create an Observability project label Jul 11, 2024
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

jennypavlova
jennypavlova approved these changes Jul 11, 2024
View reviewed changes
Copy link
Member

@jennypavlova jennypavlova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

kpatticha
kpatticha approved these changes Jul 11, 2024
View reviewed changes
Copy link
Contributor

@kpatticha kpatticha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing those 🙏

@crespocarlos crespocarlos merged commit 5df7bb8 into elastic:main Jul 11, 2024
21 checks passed
@crespocarlos crespocarlos deleted the 176948-fix-error_count_threshold-test branch July 11, 2024 11:30
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jul 11, 2024
@crespocarlos
[APM] Unskip APM alerting tests (elastic#188006)
1f89c50 
fixes [elastic#176948](elastic#176948)
fixes [elastic#177061](elastic#177061)
fixes [elastic#177104](elastic#177104)

## Summary

I managed to reproduce the problem when `error_grouping_key` was null.
It was probably fixed here elastic#184642

https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/6512

Co-authored-by: Elastic Machine <[email protected]>
(cherry picked from commit 5df7bb8)
@kibanamachine kibanamachine mentioned this pull request Jul 11, 2024
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.15

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Jul 11, 2024
@kibanamachine @crespocarlos
[8.15] [APM] Unskip APM alerting tests (#188006) (#188095)
ba8805c 
# Backport

This will backport the following commits from `main` to `8.15`:
- [[APM] Unskip APM alerting tests
(#188006)](#188006)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Carlos
Crespo","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-07-11T11:30:35Z","message":"[APM]
Unskip APM alerting tests (#188006)\n\nfixes
[#176948](https://github.com/elastic/kibana/issues/176948)\r\nfixes
[#177061](https://github.com/elastic/kibana/issues/177061)\r\nfixes
[#177104](https://github.com/elastic/kibana/issues/177104)\r\n\r\n##
Summary\r\n\r\nI managed to reproduce the problem when
`error_grouping_key` was null.\r\nIt was probably fixed here
https://github.com/elastic/kibana/pull/184642\r\n\r\n\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/6512\r\n\r\nCo-authored-by:
Elastic Machine
<[email protected]>","sha":"5df7bb87c0a9475d7f860fb45437c4624a2bd0e5","branchLabelMapping":{"^v8.16.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:prev-minor","ci:project-deploy-observability","Team:obs-ux-infra_services","v8.16.0"],"title":"[APM]
Unskip APM alerting
tests","number":188006,"url":"https://github.com/elastic/kibana/pull/188006","mergeCommit":{"message":"[APM]
Unskip APM alerting tests (#188006)\n\nfixes
[#176948](https://github.com/elastic/kibana/issues/176948)\r\nfixes
[#177061](https://github.com/elastic/kibana/issues/177061)\r\nfixes
[#177104](https://github.com/elastic/kibana/issues/177104)\r\n\r\n##
Summary\r\n\r\nI managed to reproduce the problem when
`error_grouping_key` was null.\r\nIt was probably fixed here
https://github.com/elastic/kibana/pull/184642\r\n\r\n\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/6512\r\n\r\nCo-authored-by:
Elastic Machine
<[email protected]>","sha":"5df7bb87c0a9475d7f860fb45437c4624a2bd0e5"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/188006","number":188006,"mergeCommit":{"message":"[APM]
Unskip APM alerting tests (#188006)\n\nfixes
[#176948](https://github.com/elastic/kibana/issues/176948)\r\nfixes
[#177061](https://github.com/elastic/kibana/issues/177061)\r\nfixes
[#177104](https://github.com/elastic/kibana/issues/177104)\r\n\r\n##
Summary\r\n\r\nI managed to reproduce the problem when
`error_grouping_key` was null.\r\nIt was probably fixed here
https://github.com/elastic/kibana/pull/184642\r\n\r\n\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/6512\r\n\r\nCo-authored-by:
Elastic Machine
<[email protected]>","sha":"5df7bb87c0a9475d7f860fb45437c4624a2bd0e5"}}]}]
BACKPORT-->

Co-authored-by: Carlos Crespo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kpatticha kpatticha kpatticha approved these changes

@jennypavlova jennypavlova jennypavlova approved these changes

Assignees
No one assigned
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) ci:project-deploy-observability Create an Observability project release_note:skip Skip the PR/issue when compiling release notes Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team v8.15.0 v8.16.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failing test: APM API Integration tests (basic).x-pack/test/apm_api_integration/tests/index·ts - APM API tests APM API tests alerts/transaction_error_rate.spec.ts basic no archive transaction error rate alert create rule without kql query "before all" hook for "checks if rule is active" Failing test: APM API Integration tests (basic).x-pack/test/apm_api_integration/tests/index·ts - APM API tests alerts/transaction_duration.spec.ts basic no archive transaction duration alert create rule for opbeans-node using kql filter "before each" hook for "checks if rule is active" Failing test: APM API Integration tests (basic).x-pack/test/apm_api_integration/tests/index·ts - APM API tests alerts/error_count_threshold.spec.ts basic no archive error count threshold alert create rule without kql filter "before all" hook for "checks if rule is active"
6 participants
@crespocarlos @obltmachine @kibanamachine @elasticmachine @kpatticha @jennypavlova