-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Cloud Security] Broken UI fix #188041
[Cloud Security] Broken UI fix #188041
Conversation
Pinging @elastic/kibana-cloud-security-posture (Team:Cloud Security) |
/ci |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
💚 Build Succeeded
Metrics [docs]Async chunks
|
## Summary Fix for line break tag showing up as text instead of actual line break Fix for Pipe symbol not showing properly **BEFORE** ![341360105-1705fa0f-fc9c-4068-b1bc-ae578d14b7c5](https://github.com/elastic/kibana/assets/8703149/05b5f568-70b4-44b2-9c2f-eb566d446f2a) <img width="801" alt="Screenshot 2024-07-10 at 4 53 21 PM" src="https://github.com/elastic/kibana/assets/8703149/b581814f-35e2-40e6-8718-76a21659e9fe"> **AFTER** <img width="1399" alt="Screenshot 2024-07-10 at 3 34 03 PM" src="https://github.com/elastic/kibana/assets/8703149/a1b49202-2e01-49fb-9cb0-8bf3234e778b"> <img width="641" alt="Screenshot 2024-07-10 at 4 50 50 PM" src="https://github.com/elastic/kibana/assets/8703149/b95b0036-9ac1-40a6-ad96-36a7ccf70b0a"> (cherry picked from commit 12eabcc)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
# Backport This will backport the following commits from `main` to `8.15`: - [[Cloud Security] Broken UI fix (#188041)](#188041) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Rickyanto Ang","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-07-11T01:23:13Z","message":"[Cloud Security] Broken UI fix (#188041)\n\n## Summary\r\n\r\nFix for line break tag showing up as text instead of actual line break \r\nFix for Pipe symbol not showing properly\r\n\r\n**BEFORE**\r\n\r\n![341360105-1705fa0f-fc9c-4068-b1bc-ae578d14b7c5](https://github.com/elastic/kibana/assets/8703149/05b5f568-70b4-44b2-9c2f-eb566d446f2a)\r\n<img width=\"801\" alt=\"Screenshot 2024-07-10 at 4 53 21 PM\"\r\nsrc=\"https://github.com/elastic/kibana/assets/8703149/b581814f-35e2-40e6-8718-76a21659e9fe\">\r\n\r\n\r\n**AFTER**\r\n<img width=\"1399\" alt=\"Screenshot 2024-07-10 at 3 34 03 PM\"\r\nsrc=\"https://github.com/elastic/kibana/assets/8703149/a1b49202-2e01-49fb-9cb0-8bf3234e778b\">\r\n<img width=\"641\" alt=\"Screenshot 2024-07-10 at 4 50 50 PM\"\r\nsrc=\"https://github.com/elastic/kibana/assets/8703149/b95b0036-9ac1-40a6-ad96-36a7ccf70b0a\">","sha":"12eabcc7e227af7b9b1ef90156df9a68c448e78c","branchLabelMapping":{"^v8.16.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Cloud Security","backport:prev-minor","v8.15.0","v8.16.0"],"title":"[Cloud Security] Broken UI fix","number":188041,"url":"https://github.com/elastic/kibana/pull/188041","mergeCommit":{"message":"[Cloud Security] Broken UI fix (#188041)\n\n## Summary\r\n\r\nFix for line break tag showing up as text instead of actual line break \r\nFix for Pipe symbol not showing properly\r\n\r\n**BEFORE**\r\n\r\n![341360105-1705fa0f-fc9c-4068-b1bc-ae578d14b7c5](https://github.com/elastic/kibana/assets/8703149/05b5f568-70b4-44b2-9c2f-eb566d446f2a)\r\n<img width=\"801\" alt=\"Screenshot 2024-07-10 at 4 53 21 PM\"\r\nsrc=\"https://github.com/elastic/kibana/assets/8703149/b581814f-35e2-40e6-8718-76a21659e9fe\">\r\n\r\n\r\n**AFTER**\r\n<img width=\"1399\" alt=\"Screenshot 2024-07-10 at 3 34 03 PM\"\r\nsrc=\"https://github.com/elastic/kibana/assets/8703149/a1b49202-2e01-49fb-9cb0-8bf3234e778b\">\r\n<img width=\"641\" alt=\"Screenshot 2024-07-10 at 4 50 50 PM\"\r\nsrc=\"https://github.com/elastic/kibana/assets/8703149/b95b0036-9ac1-40a6-ad96-36a7ccf70b0a\">","sha":"12eabcc7e227af7b9b1ef90156df9a68c448e78c"}},"sourceBranch":"main","suggestedTargetBranches":["8.15"],"targetPullRequestStates":[{"branch":"8.15","label":"v8.15.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/188041","number":188041,"mergeCommit":{"message":"[Cloud Security] Broken UI fix (#188041)\n\n## Summary\r\n\r\nFix for line break tag showing up as text instead of actual line break \r\nFix for Pipe symbol not showing properly\r\n\r\n**BEFORE**\r\n\r\n![341360105-1705fa0f-fc9c-4068-b1bc-ae578d14b7c5](https://github.com/elastic/kibana/assets/8703149/05b5f568-70b4-44b2-9c2f-eb566d446f2a)\r\n<img width=\"801\" alt=\"Screenshot 2024-07-10 at 4 53 21 PM\"\r\nsrc=\"https://github.com/elastic/kibana/assets/8703149/b581814f-35e2-40e6-8718-76a21659e9fe\">\r\n\r\n\r\n**AFTER**\r\n<img width=\"1399\" alt=\"Screenshot 2024-07-10 at 3 34 03 PM\"\r\nsrc=\"https://github.com/elastic/kibana/assets/8703149/a1b49202-2e01-49fb-9cb0-8bf3234e778b\">\r\n<img width=\"641\" alt=\"Screenshot 2024-07-10 at 4 50 50 PM\"\r\nsrc=\"https://github.com/elastic/kibana/assets/8703149/b95b0036-9ac1-40a6-ad96-36a7ccf70b0a\">","sha":"12eabcc7e227af7b9b1ef90156df9a68c448e78c"}}]}] BACKPORT--> Co-authored-by: Rickyanto Ang <[email protected]>
Summary
Fix for line break tag showing up as text instead of actual line break
Fix for Pipe symbol not showing properly
BEFORE
AFTER