Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.15] [APM] Unskip APM alerting tests (#188006) #188095

Merged
merged 1 commit into from
Jul 11, 2024
Merged

[8.15] [APM] Unskip APM alerting tests (#188006) #188095

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 6 additions & 8 deletions x-pack/test/apm_api_integration/tests/alerts/error_count_threshold.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,8 +103,7 @@ export default function ApiTest({ getService }: FtrProviderContext) {

after(() => apmSynthtraceEsClient.clean());

// FLAKY: https://github.com/elastic/kibana/issues/176948
describe.skip('create rule without kql filter', () => {
describe('create rule without kql filter', () => {
let ruleId: string;
let alerts: ApmAlertFields[];
let actionId: string;
Expand Down Expand Up @@ -175,10 +174,10 @@ export default function ApiTest({ getService }: FtrProviderContext) {
environment: 'production',
interval: '1 hr',
reason:
'Error count is 30 in the last 1 hr for service: opbeans-php, env: production, name: tx-php, error key: c85df8159a74b47b461d6ddaa6ba7da38cfc3e74019aef66257d10df74adeb99, error name: a php error. Alert when > 1.',
'Error count is 30 in the last 1 hr for service: opbeans-php, env: production, name: tx-php, error key: 000000000000000000000a php error, error name: a php error. Alert when > 1.',
serviceName: 'opbeans-php',
transactionName: 'tx-php',
errorGroupingKey: 'c85df8159a74b47b461d6ddaa6ba7da38cfc3e74019aef66257d10df74adeb99',
errorGroupingKey: '000000000000000000000a php error',
errorGroupingName: 'a php error',
threshold: '1',
triggerValue: '30',
Expand All @@ -192,8 +191,8 @@ export default function ApiTest({ getService }: FtrProviderContext) {
const alertReasons = [alerts[0]['kibana.alert.reason'], alerts[1]['kibana.alert.reason']];

expect(alertReasons).to.eql([
'Error count is 30 in the last 1 hr for service: opbeans-php, env: production, name: tx-php, error key: c85df8159a74b47b461d6ddaa6ba7da38cfc3e74019aef66257d10df74adeb99, error name: a php error. Alert when > 1.',
'Error count is 15 in the last 1 hr for service: opbeans-java, env: production, name: tx-java, error key: b6a4ac83620b34ae44dd98a13e144782f88698f827af7edb10690c5e6e7d8597, error name: a java error. Alert when > 1.',
'Error count is 30 in the last 1 hr for service: opbeans-php, env: production, name: tx-php, error key: 000000000000000000000a php error, error name: a php error. Alert when > 1.',
'Error count is 15 in the last 1 hr for service: opbeans-java, env: production, name: tx-java, error key: 00000000000000000000a java error, error name: a java error. Alert when > 1.',
]);
});

Expand Down Expand Up @@ -252,8 +251,7 @@ export default function ApiTest({ getService }: FtrProviderContext) {
});
});

// FLAKY: https://github.com/elastic/kibana/issues/176964
describe.skip('create rule with kql filter for opbeans-php', () => {
describe('create rule with kql filter for opbeans-php', () => {
let ruleId: string;

before(async () => {
Expand Down
6 changes: 2 additions & 4 deletions x-pack/test/apm_api_integration/tests/alerts/transaction_duration.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,8 +75,7 @@ export default function ApiTest({ getService }: FtrProviderContext) {
await apmSynthtraceEsClient.clean();
});

// FLAKY: https://github.com/elastic/kibana/issues/176996
describe.skip('create rule for opbeans-java without kql filter', () => {
describe('create rule for opbeans-java without kql filter', () => {
let ruleId: string;
let actionId: string;
let alerts: ApmAlertFields[];
Expand Down Expand Up @@ -188,8 +187,7 @@ export default function ApiTest({ getService }: FtrProviderContext) {
});
});

// FLAKY: https://github.com/elastic/kibana/issues/177061
describe.skip('create rule for opbeans-node using kql filter', () => {
describe('create rule for opbeans-node using kql filter', () => {
let ruleId: string;
let alerts: ApmAlertFields[];

Expand Down
2 changes: 0 additions & 2 deletions x-pack/test/apm_api_integration/tests/alerts/transaction_error_rate.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,6 @@ export default function ApiTest({ getService }: FtrProviderContext) {
await apmSynthtraceEsClient.clean();
});

// FLAKY: https://github.com/elastic/kibana/issues/177104
describe('create rule without kql query', () => {
let ruleId: string;
let actionId: string;
Expand Down Expand Up @@ -197,7 +196,6 @@ export default function ApiTest({ getService }: FtrProviderContext) {
});
});

// FLAKY: https://github.com/elastic/kibana/issues/177108
describe('create rule with kql query', () => {
let ruleId: string;
let alerts: ApmAlertFields[];
Expand Down