Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ObsUX][APM] Rename observability setting apmEnableMultiSignal to entityCentricExperience #188097

Conversation

jennypavlova
Copy link
Member

@jennypavlova jennypavlova commented Jul 11, 2024

Closes https://github.com/elastic/observability-dev/issues/3731

Summary

This PR rename apmEnableMultiSignal to entityCentricExperience

image

@jennypavlova jennypavlova added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team labels Jul 11, 2024
@jennypavlova jennypavlova self-assigned this Jul 11, 2024
@jennypavlova jennypavlova requested review from a team as code owners July 11, 2024 11:58
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

@botelastic botelastic bot added ci:project-deploy-observability Create an Observability project Team:obs-ux-management Observability Management User Experience Team labels Jul 11, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

@obltmachine
Copy link

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

Copy link
Member

@bmorelli25 bmorelli25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On the documentation side, please take a look at our config docs and make sure there are no changes or entries needed. Thanks! Approving to unblock.

Copy link
Contributor

@dominiqueclarke dominiqueclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like users who have previously opted into apmEnableMultiSignal will need to re-opt into the new setting. Is that intended?

@jennypavlova
Copy link
Member Author

It seems like users who have previously opted into apmEnableMultiSignal will need to re-opt into the new setting. Is that intended?

My understanding is that we want to replace this flag and as this is a new feature it should be fine to have the new flag instead (and ignore the old one). @roshan-elastic is that correct?

I think it will make sense to backport it to 8.15 as this flag has not been released yet and we can have it there with the new name directly

@jennypavlova jennypavlova added backport:all-open Backport to all branches that could still receive a release and removed backport:skip This commit does not require backporting labels Jul 11, 2024
@roshan-elastic
Copy link

My understanding is that we want to replace this flag and as this is a new feature it should be fine to have the new flag instead (and ignore the old one). @roshan-elastic is that correct?

I think it will make sense to backport it to 8.15 as this flag has not been released yet and we can have it there with the new name directly

Yeah @jennypavlova - that's right. The existing feature flag was off by default and it's unlikely anyone ever found it (it was only in stack management). Even if they turned it on, it wouldn't have really done anything. When I tested, it basically just made APM blank (presumably it was work in progress still).

Copy link
Contributor

@dominiqueclarke dominiqueclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@smith
Copy link
Contributor

smith commented Jul 11, 2024

Changing it isn't a problem like Roshan said, but it recommended to migrate them. I don't think it's necessary here.

Copy link
Contributor

@crespocarlos crespocarlos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

There are still a few things besides this setting named "multi signal". Are we planning on renaming those too?

@jennypavlova
Copy link
Member Author

There are still a few things besides this setting named "multi signal". Are we planning on renaming those too?

@crespocarlos As mentioned here we are renaming it because we will include multiple experiences under the same feature flag, IMO multi signal is still valid for the component names, please let me know if you think otherwise.

@crespocarlos
Copy link
Contributor

@crespocarlos As mentioned here we are renaming it because we will include multiple experiences under the same feature flag, IMO multi signal is still valid for the component names, please let me know if you think otherwise.

Yeah. multi signal makes sense as you said. Thanks!

@jennypavlova
Copy link
Member Author

On the documentation side, please take a look at our config docs and make sure there are no changes or entries needed. Thanks! Approving to unblock.

@bmorelli25 The feature flag was not there before I renamed it so I can confirm that I didn't change anything there. I guess we don't need any changes there in this case, right?

defaultMessage:
'{technicalPreviewLabel} Enable the multi-signal feature in APM, which allows you to monitor services from logs and traces.',
description: i18n.translate('xpack.observability.entityCentricExperienceDescription', {
defaultMessage: '{technicalPreviewLabel} Promote entity-centric experience to users.',
Copy link
Contributor

@cauemarcondes cauemarcondes Jul 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a better description here? It doesn't say much more than the title itself. Maybe @mdbirnstiehl could help?!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jennypavlova jennypavlova merged commit 9291a4f into elastic:main Jul 15, 2024
25 checks passed
@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
7.17 Backport failed because of merge conflicts
8.15 Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 188097

Questions ?

Please refer to the Backport tool documentation

@jennypavlova
Copy link
Member Author

💚 All backports created successfully

Status Branch Result
8.15

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

jennypavlova added a commit to jennypavlova/kibana that referenced this pull request Jul 15, 2024
…entityCentricExperience` (elastic#188097)

Closes elastic/observability-dev#3731

## Summary

This PR rename `apmEnableMultiSignal` to `entityCentricExperience`

<img width="1834" alt="image"
src="https://github.com/elastic/kibana/assets/14139027/bc8dfcf6-f739-4215-9f68-47345fbdef5e">

Co-authored-by: Katerina <[email protected]>
(cherry picked from commit 9291a4f)

# Conflicts:
#	packages/kbn-management/settings/setting_ids/index.ts
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Sep 3, 2024
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

1 similar comment
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@smith smith added backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) and removed backport missing Added to PRs automatically when the are determined to be missing a backport. backport:all-open Backport to all branches that could still receive a release labels Sep 30, 2024
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/11114971159

@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
8.x Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 188097

Questions ?

Please refer to the Backport tool documentation

@afharo afharo added the auto-backport Deprecated - use backport:version if exact versions are needed label Oct 1, 2024
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/11121442959

@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
8.x Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 188097

Questions ?

Please refer to the Backport tool documentation

@afharo
Copy link
Member

afharo commented Oct 1, 2024

Based on this comment, I'll switch this PR to backport:skip

@afharo afharo removed the auto-backport Deprecated - use backport:version if exact versions are needed label Oct 1, 2024
@afharo afharo assigned jennypavlova and unassigned jennypavlova Oct 1, 2024
@afharo afharo added backport:skip This commit does not require backporting and removed backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) labels Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting ci:project-deploy-observability Create an Observability project release_note:skip Skip the PR/issue when compiling release notes Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team Team:obs-ux-management Observability Management User Experience Team v8.16.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.