Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ES|QL] Add AST helper for finding functions #188212

Merged
merged 2 commits into from
Jul 16, 2024
Merged

[ES|QL] Add AST helper for finding functions #188212

merged 2 commits into from
Jul 16, 2024

Conversation

vadimkibana
Copy link
Contributor

@vadimkibana vadimkibana commented Jul 12, 2024 •
edited
Loading

Summary

The ES|QL METRICS command support work is currently on pause, as its syntax in ES will likely change. Meanwhile this PR extracts an AST helper added in this paused PR which allows to find function in an AST subtree.

  • Walker.fincFunction
  • Walker.hasFunction

Checklist

Delete any items that are not applicable to this PR.

  • Documentation was added for features that require explanation or tutorials

For maintainers

@vadimkibana vadimkibana marked this pull request as ready for review July 12, 2024 12:36
@vadimkibana vadimkibana requested a review from a team as a code owner July 12, 2024 12:36
@vadimkibana vadimkibana added review release_note:skip Skip the PR/issue when compiling release notes Team:DataDiscovery Discover App Team (Document Explorer, Saved Search, Surrounding documents, Data, DataViews) Feature:ES|QL ES|QL related features in Kibana Team:ESQL ES|QL related features in Kibana v8.16.0 labels Jul 12, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-esql (Team:ESQL)

stratoula
stratoula approved these changes Jul 15, 2024
View reviewed changes
Copy link
Contributor

@stratoula stratoula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cute

drewdaemon
drewdaemon approved these changes Jul 15, 2024
View reviewed changes
Copy link
Contributor

@drewdaemon drewdaemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
kbnUiSharedDeps-srcJs 3.2MB 3.2MB +161.0B
Unknown metric groups

API count

id before after diff
@kbn/esql-ast 104 110 +6

@vadimkibana vadimkibana merged commit c40dc3e into elastic:main Jul 16, 2024
22 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drewdaemon drewdaemon drewdaemon approved these changes

@stratoula stratoula stratoula approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting Feature:ES|QL ES|QL related features in Kibana release_note:skip Skip the PR/issue when compiling release notes review Team:DataDiscovery Discover App Team (Document Explorer, Saved Search, Surrounding documents, Data, DataViews) Team:ESQL ES|QL related features in Kibana v8.16.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vadimkibana @elasticmachine @drewdaemon @stratoula @kibanamachine