Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Build] Fix Windows Node path #188271

Merged
merged 5 commits into from
Jul 15, 2024

Conversation

Ikuni17
Copy link
Contributor

@Ikuni17 Ikuni17 commented Jul 12, 2024

Summary

Closes #188175

This path wasn't updated as part of #184675

@Ikuni17 Ikuni17 added Team:Operations Team label for Operations Team release_note:skip Skip the PR/issue when compiling release notes ci:build-all-platforms backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) v8.15.0 v8.16.0 labels Jul 12, 2024
@Ikuni17 Ikuni17 self-assigned this Jul 12, 2024
@Ikuni17 Ikuni17 requested a review from a team as a code owner July 12, 2024 23:42
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@Ikuni17
Copy link
Contributor Author

Ikuni17 commented Jul 15, 2024

/ci

@Ikuni17 Ikuni17 enabled auto-merge (squash) July 15, 2024 16:30
@Ikuni17 Ikuni17 merged commit 58c82e8 into elastic:main Jul 15, 2024
19 checks passed
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

cc @Ikuni17

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jul 15, 2024
## Summary

Closes elastic#188175

This path wasn't updated as part of elastic#184675

(cherry picked from commit 58c82e8)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.15

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Jul 15, 2024
# Backport

This will backport the following commits from `main` to `8.15`:
- [[Build] Fix Windows Node path
(#188271)](#188271)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Brad
White","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-07-15T18:02:27Z","message":"[Build]
Fix Windows Node path (#188271)\n\n## Summary\r\n\r\nCloses
#188175\r\n\r\nThis path wasn't updated as part of
#184675","sha":"58c82e8f81e7768dbe92f0bd7c6a6ddb2f76d526","branchLabelMapping":{"^v8.16.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Operations","release_note:skip","backport:prev-minor","v8.15.0","v8.16.0"],"title":"[Build]
Fix Windows Node
path","number":188271,"url":"https://github.com/elastic/kibana/pull/188271","mergeCommit":{"message":"[Build]
Fix Windows Node path (#188271)\n\n## Summary\r\n\r\nCloses
#188175\r\n\r\nThis path wasn't updated as part of
#184675","sha":"58c82e8f81e7768dbe92f0bd7c6a6ddb2f76d526"}},"sourceBranch":"main","suggestedTargetBranches":["8.15"],"targetPullRequestStates":[{"branch":"8.15","label":"v8.15.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/188271","number":188271,"mergeCommit":{"message":"[Build]
Fix Windows Node path (#188271)\n\n## Summary\r\n\r\nCloses
#188175\r\n\r\nThis path wasn't updated as part of
#184675","sha":"58c82e8f81e7768dbe92f0bd7c6a6ddb2f76d526"}}]}]
BACKPORT-->

Co-authored-by: Brad White <[email protected]>
@Ikuni17 Ikuni17 deleted the fix/188175/kibana-bat-node-not-found branch July 15, 2024 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v8.15.0 v8.16.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

node.js is missing from Kibana artifact and shows unable to find usable node.js executable. error on Windows
4 participants