Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Search][Homepage] Indices Card #188491

Conversation

TattdCodeMonkey
Copy link
Contributor

@TattdCodeMonkey TattdCodeMonkey commented Jul 16, 2024

Summary

Introduces the Indices card for the (feature flagged) search homepage.

Testing

To enable the Search Home page execute the following command in the Dev Console:

POST kbn:/internal/kibana/settings/searchHomepage:homepageEnabled
{"value": true}

You can then disable the feature flag with the following command:

DELETE kbn:/internal/kibana/settings/searchHomepage:homepageEnabled

Screenshots

Empty State
image
Stack w/ Index
image

Checklist

Delete any items that are not applicable to this PR.

@TattdCodeMonkey TattdCodeMonkey added release_note:skip Skip the PR/issue when compiling release notes Team:Search v8.16.0 labels Jul 16, 2024
@TattdCodeMonkey TattdCodeMonkey marked this pull request as ready for review July 22, 2024 16:18
@TattdCodeMonkey TattdCodeMonkey requested review from a team as code owners July 22, 2024 16:18
Added a config value to set if getting index stats is available. for ES3
we will not be able to fetch index stats so we need an easy way to
disable this in routes that fetch index data.
Added the get indices route with support for stack and serverless.
@TattdCodeMonkey
Copy link
Contributor Author

/ci

Removed the import of the ent-search context. Instead we will need to
share search context in another way that doesn't result in circular
references :/
Copy link
Member

@afharo afharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Core changes LGTM

Copy link
Contributor

@elena-shostak elena-shostak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
enterpriseSearch 2296 2297 +1
searchHomepage 152 172 +20
serverlessSearch 281 282 +1
total +22

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
enterpriseSearch 5 6 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
searchHomepage 54.8KB 66.7KB +12.0KB

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
enterpriseSearch 0 1 +1

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
enterpriseSearch 53.4KB 53.7KB +298.0B
searchHomepage 4.8KB 4.9KB +182.0B
serverlessSearch 20.6KB 21.0KB +367.0B
total +847.0B
Unknown metric groups

API count

id before after diff
enterpriseSearch 5 6 +1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@TattdCodeMonkey TattdCodeMonkey deleted the search-homepage/indices-card branch August 2, 2024 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Search v8.16.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants