Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert 8.x to 8.16 in doc link service #192794

Merged
merged 5 commits into from
Sep 18, 2024
Merged

Convert 8.x to 8.16 in doc link service #192794

merged 5 commits into from
Sep 18, 2024

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented Sep 13, 2024 •
edited
Loading

Summary

Relates to elastic/docs#3068

The purpose is to use URLs that include "8.16" instead of "8.x".

@lcawl lcawl added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting labels Sep 13, 2024
@obltmachine
Copy link

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@lcawl lcawl marked this pull request as ready for review September 13, 2024 18:42
@lcawl lcawl marked this pull request as draft September 13, 2024 20:27
@lcawl lcawl marked this pull request as ready for review September 17, 2024 21:35
@lcawl lcawl requested a review from a team September 17, 2024 21:35
karenzone
karenzone approved these changes Sep 17, 2024
View reviewed changes
Copy link
Contributor

@karenzone karenzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lcawl lcawl marked this pull request as draft September 18, 2024 01:20
@lcawl lcawl marked this pull request as ready for review September 18, 2024 01:37
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #6 / useGetEndpointDetails hook should call the proper API

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
aiAssistantManagementSelection 90.9KB 90.9KB +17.0B
lists 143.4KB 143.4KB +17.0B
total +34.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
core 418.9KB 418.9KB +17.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@lcawl lcawl merged commit 73ac7f0 into elastic:8.x Sep 18, 2024
21 checks passed
@lcawl lcawl deleted the 8x-doclinks branch September 18, 2024 14:17
lcawl added a commit that referenced this pull request Oct 17, 2024
@lcawl
Revert "Convert 8.x to 8.16 in doc link service (#192794)"
58940bf 
This reverts commit 73ac7f0.
@lcawl lcawl mentioned this pull request Oct 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karenzone karenzone karenzone approved these changes

@pgayvallet pgayvallet Awaiting requested review from pgayvallet

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lcawl @obltmachine @kibana-ci @karenzone