[APM][Otel] Fix an error with mobile services coming from synthtrace #196313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jennypavlova
added
release_note:skip
|
Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services) |
botelastic
bot
added
the
ci:project-deploy-observability
| @@ -230,7 +230,7 @@ export class MobileDevice extends Entity<ApmFields> { | |||
| spanSubtype: 'http', | |||
| 'http.request.method': httpMethod, | |||
| 'url.original': httpUrl, | |||
| 'transaction.type': 'mobile', | |||
| 'processor.event': 'span', | |||
There was a problem hiding this comment.
I think it was set because of the parent transaction - it is set there but inside the span function we are not setting the transaction.type so that's why some spans were visible and the httpSpans were throwing an error. I don't see any test checking it and it's not part of any span-specific fields so I guess it was something we had copied from the transaction 🤔
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]
History |
jennypavlova
added
backport:version
|
Starting backport for target branches: 8.x |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 15, 2024
…lastic#196313) Closes elastic#196161 ## Summary This PR fixes an issue with the mobile data using synthtrace. After some investigation I saw that the the `httpSpan` was creating the spans with `transaction.type` set which resulted in `processor.event` being set to `transaction` instead of `span` - then with [the new required transaction fields](https://github.com/elastic/kibana/blob/adb558a86bafbe3567915c3fae252ff414147930/x-pack/plugins/observability_solution/apm/server/routes/traces/get_trace_items.ts#L277) in get_trace_docs for transactions ([checking based on the processor.event](https://github.com/elastic/kibana/blob/adb558a86bafbe3567915c3fae252ff414147930/x-pack/plugins/observability_solution/apm/server/routes/traces/get_trace_items.ts#L352)) we were throwing an error because the transaction fields were not defined (which is expected because it's a span and not a transaction) ## Testing Generate mobile data using: `node scripts/synthtrace mobile.ts --clean` Open all the mobile traces (ios/Android) - there should not be an error (cherry picked from commit c218e7c)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 15, 2024
…trace (#196313) (#196357) # Backport This will backport the following commits from `main` to `8.x`: - [[APM][Otel] Fix an error with mobile services coming from synthtrace (#196313)](#196313) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"jennypavlova","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-15T15:53:12Z","message":"[APM][Otel] Fix an error with mobile services coming from synthtrace (#196313)\n\nCloses #196161 \r\n## Summary\r\n\r\nThis PR fixes an issue with the mobile data using synthtrace. After some\r\ninvestigation I saw that the the `httpSpan` was creating the spans with\r\n`transaction.type` set which resulted in `processor.event` being set to\r\n`transaction` instead of `span` - then with [the new required\r\ntransaction\r\nfields](https://github.com/elastic/kibana/blob/adb558a86bafbe3567915c3fae252ff414147930/x-pack/plugins/observability_solution/apm/server/routes/traces/get_trace_items.ts#L277)\r\nin get_trace_docs for transactions ([checking based on the\r\nprocessor.event](https://github.com/elastic/kibana/blob/adb558a86bafbe3567915c3fae252ff414147930/x-pack/plugins/observability_solution/apm/server/routes/traces/get_trace_items.ts#L352))\r\nwe were throwing an error because the transaction fields were not\r\ndefined (which is expected because it's a span and not a transaction)\r\n\r\n## Testing \r\n\r\nGenerate mobile data using:\r\n`node scripts/synthtrace mobile.ts --clean`\r\n\r\nOpen all the mobile traces (ios/Android) - there should not be an error","sha":"c218e7cc29c00864d744d886c6e712b99ba97ed5","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","ci:project-deploy-observability","Team:obs-ux-infra_services","v8.16.0","backport:version"],"title":"[APM][Otel] Fix an error with mobile services coming from synthtrace","number":196313,"url":"https://github.com/elastic/kibana/pull/196313","mergeCommit":{"message":"[APM][Otel] Fix an error with mobile services coming from synthtrace (#196313)\n\nCloses #196161 \r\n## Summary\r\n\r\nThis PR fixes an issue with the mobile data using synthtrace. After some\r\ninvestigation I saw that the the `httpSpan` was creating the spans with\r\n`transaction.type` set which resulted in `processor.event` being set to\r\n`transaction` instead of `span` - then with [the new required\r\ntransaction\r\nfields](https://github.com/elastic/kibana/blob/adb558a86bafbe3567915c3fae252ff414147930/x-pack/plugins/observability_solution/apm/server/routes/traces/get_trace_items.ts#L277)\r\nin get_trace_docs for transactions ([checking based on the\r\nprocessor.event](https://github.com/elastic/kibana/blob/adb558a86bafbe3567915c3fae252ff414147930/x-pack/plugins/observability_solution/apm/server/routes/traces/get_trace_items.ts#L352))\r\nwe were throwing an error because the transaction fields were not\r\ndefined (which is expected because it's a span and not a transaction)\r\n\r\n## Testing \r\n\r\nGenerate mobile data using:\r\n`node scripts/synthtrace mobile.ts --clean`\r\n\r\nOpen all the mobile traces (ios/Android) - there should not be an error","sha":"c218e7cc29c00864d744d886c6e712b99ba97ed5"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/196313","number":196313,"mergeCommit":{"message":"[APM][Otel] Fix an error with mobile services coming from synthtrace (#196313)\n\nCloses #196161 \r\n## Summary\r\n\r\nThis PR fixes an issue with the mobile data using synthtrace. After some\r\ninvestigation I saw that the the `httpSpan` was creating the spans with\r\n`transaction.type` set which resulted in `processor.event` being set to\r\n`transaction` instead of `span` - then with [the new required\r\ntransaction\r\nfields](https://github.com/elastic/kibana/blob/adb558a86bafbe3567915c3fae252ff414147930/x-pack/plugins/observability_solution/apm/server/routes/traces/get_trace_items.ts#L277)\r\nin get_trace_docs for transactions ([checking based on the\r\nprocessor.event](https://github.com/elastic/kibana/blob/adb558a86bafbe3567915c3fae252ff414147930/x-pack/plugins/observability_solution/apm/server/routes/traces/get_trace_items.ts#L352))\r\nwe were throwing an error because the transaction fields were not\r\ndefined (which is expected because it's a span and not a transaction)\r\n\r\n## Testing \r\n\r\nGenerate mobile data using:\r\n`node scripts/synthtrace mobile.ts --clean`\r\n\r\nOpen all the mobile traces (ios/Android) - there should not be an error","sha":"c218e7cc29c00864d744d886c6e712b99ba97ed5"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: jennypavlova <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #196161
Summary
This PR fixes an issue with the mobile data using synthtrace. After some investigation I saw that the the
httpSpanwas creating the spans withtransaction.typeset which resulted inprocessor.eventbeing set totransactioninstead ofspan- then with the new required transaction fields in get_trace_docs for transactions (checking based on the processor.event) we were throwing an error because the transaction fields were not defined (which is expected because it's a span and not a transaction)Testing
Generate mobile data using:
node scripts/synthtrace mobile.ts --cleanOpen all the mobile traces (ios/Android) - there should not be an error