[Entity Analytics] [Entity Store] Add audit logs #196847
Merged
+173
−44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiansivive
added
release_note:skip
|
Pinging @elastic/security-entity-analytics (Team:Entity Analytics) |
hop-dev
added
v9.0.0
v8.16.0
backport:version
tiansivive
force-pushed
the
ea-audit-10566
branch
from
a84bf11
to
7fe4989
Compare
machadoum
reviewed
Oct 24, 2024
| // This may change in the future, depending on the audit action. | ||
| const outcome = error ? AUDIT_OUTCOME.FAILURE : AUDIT_OUTCOME.UNKNOWN; | ||
|
|
||
| // QUESTION: For EXECUTE action: Maybe START is better: https://www.elastic.co/guide/en/ecs/8.11/ecs-allowed-values-event-type.html#ecs-event-type-start |
There was a problem hiding this comment.
Should we clarify al questions before merging the PR? Otherwise, we will have inconsistent audit logs.
There was a problem hiding this comment.
We went through it at standup. I've removed the extra audit logs which makes the questions raised obsolete, so I've removed the comments.
Leaving the note one as I think that one is important for any future work here
| const descriptor = await this.engineClient.get(entityType); | ||
| if (!options?.force && descriptor.status !== ENGINE_STATUS.STOPPED) { | ||
| throw new Error( | ||
| `In namespace ${this.options.namespace}: Cannot start Entity engine for ${entityType} when current status is: ${descriptor.status}` | ||
| `In namespace ${namespace}: Cannot start Entity engine for ${entityType} when current status is: ${descriptor.status}` |
There was a problem hiding this comment.
Unrelated: We should return the error message when the status is an error.
There was a problem hiding this comment.
But if we throw it just gets caught by any catch handlers in the requests, no?
| const descriptor = await this.engineClient.get(entityType); | ||
|
|
||
| if (descriptor.status !== ENGINE_STATUS.STARTED) { | ||
| throw new Error( | ||
| `In namespace ${this.options.namespace}: Cannot stop Entity engine for ${entityType} when current status is: ${descriptor.status}` | ||
| `In namespace ${namespace}: Cannot stop Entity engine for ${entityType} when current status is: ${descriptor.status}` |
There was a problem hiding this comment.
same thing here and all other similar checks
...ugins/security_solution/server/lib/entity_analytics/entity_store/entity_store_data_client.ts
Outdated
Show resolved
Hide resolved
hop-dev
reviewed
Oct 25, 2024
...ugins/security_solution/server/lib/entity_analytics/entity_store/entity_store_data_client.ts
Outdated
Show resolved
Hide resolved
machadoum
approved these changes
Oct 28, 2024
|
Starting backport for target branches: 8.16, 8.x |
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]
History
cc @tiansivive |
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds audit logs for the different actions that can be performed on the entity store engines.