[ES|QL] AddSORT command mutation APIs
#197185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/ci |
vadimkibana
changed the title
SORT command mutation APIs
vadimkibana
added
review
release_note:skip
|
Pinging @elastic/kibana-esql (Team:ESQL) |
💚 Build Succeeded
Metrics [docs]Page load bundle
History
|
|
Starting backport for target branches: 8.x |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 30, 2024
## Summary Partially addresses elastic#191812 - Adds traversal and manipulation APIs for `SORT` command. - `commands.sort.listCommands()` - `commands.sort.getCommand()` - `commands.sort.list()` - `commands.sort.findByPredicate()` - `commands.sort.find()` - `commands.sort.remove()` - `commands.sort.insertIntoCommand()` - `commands.sort.insertExpression()` - `commands.sort.insertCommand()` - Refactors "generic" AST manipulation routines into (1) `commands`, (2) `commands.args`, (3) `commands.options`. - `generic.commands.*` - `generic.commands.args.*` - `generic.commands.options.*` ### Checklist Delete any items that are not applicable to this PR. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios ### For maintainers - [x] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#_add_your_labels) --------- Co-authored-by: Stratoula Kalafateli <[email protected]> (cherry picked from commit 0cc8945)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 30, 2024
…98440) # Backport This will backport the following commits from `main` to `8.x`: - [[ES|QL] Add`SORT` command mutation APIs (#197185)](#197185) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Vadim Kibana","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-30T20:34:57Z","message":"[ES|QL] Add`SORT` command mutation APIs (#197185)\n\n## Summary\r\n\r\nPartially addresses https://github.com/elastic/kibana/issues/191812\r\n\r\n- Adds traversal and manipulation APIs for `SORT` command.\r\n - `commands.sort.listCommands()`\r\n - `commands.sort.getCommand()`\r\n - `commands.sort.list()`\r\n - `commands.sort.findByPredicate()`\r\n - `commands.sort.find()`\r\n - `commands.sort.remove()`\r\n - `commands.sort.insertIntoCommand()`\r\n - `commands.sort.insertExpression()`\r\n - `commands.sort.insertCommand()`\r\n- Refactors \"generic\" AST manipulation routines into (1) `commands`, (2)\r\n`commands.args`, (3) `commands.options`.\r\n - `generic.commands.*`\r\n - `generic.commands.args.*`\r\n - `generic.commands.options.*`\r\n\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n### For maintainers\r\n\r\n- [x] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#_add_your_labels)\r\n\r\n---------\r\n\r\nCo-authored-by: Stratoula Kalafateli <[email protected]>","sha":"0cc89457124f9cefbdd08766a7a22b1c4bdcc440","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["review","release_note:skip","v9.0.0","backport:prev-minor","Feature:ES|QL","Team:ESQL","v8.17.0"],"title":"[ES|QL] Add`SORT` command mutation APIs","number":197185,"url":"https://github.com/elastic/kibana/pull/197185","mergeCommit":{"message":"[ES|QL] Add`SORT` command mutation APIs (#197185)\n\n## Summary\r\n\r\nPartially addresses https://github.com/elastic/kibana/issues/191812\r\n\r\n- Adds traversal and manipulation APIs for `SORT` command.\r\n - `commands.sort.listCommands()`\r\n - `commands.sort.getCommand()`\r\n - `commands.sort.list()`\r\n - `commands.sort.findByPredicate()`\r\n - `commands.sort.find()`\r\n - `commands.sort.remove()`\r\n - `commands.sort.insertIntoCommand()`\r\n - `commands.sort.insertExpression()`\r\n - `commands.sort.insertCommand()`\r\n- Refactors \"generic\" AST manipulation routines into (1) `commands`, (2)\r\n`commands.args`, (3) `commands.options`.\r\n - `generic.commands.*`\r\n - `generic.commands.args.*`\r\n - `generic.commands.options.*`\r\n\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n### For maintainers\r\n\r\n- [x] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#_add_your_labels)\r\n\r\n---------\r\n\r\nCo-authored-by: Stratoula Kalafateli <[email protected]>","sha":"0cc89457124f9cefbdd08766a7a22b1c4bdcc440"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/197185","number":197185,"mergeCommit":{"message":"[ES|QL] Add`SORT` command mutation APIs (#197185)\n\n## Summary\r\n\r\nPartially addresses https://github.com/elastic/kibana/issues/191812\r\n\r\n- Adds traversal and manipulation APIs for `SORT` command.\r\n - `commands.sort.listCommands()`\r\n - `commands.sort.getCommand()`\r\n - `commands.sort.list()`\r\n - `commands.sort.findByPredicate()`\r\n - `commands.sort.find()`\r\n - `commands.sort.remove()`\r\n - `commands.sort.insertIntoCommand()`\r\n - `commands.sort.insertExpression()`\r\n - `commands.sort.insertCommand()`\r\n- Refactors \"generic\" AST manipulation routines into (1) `commands`, (2)\r\n`commands.args`, (3) `commands.options`.\r\n - `generic.commands.*`\r\n - `generic.commands.args.*`\r\n - `generic.commands.options.*`\r\n\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n### For maintainers\r\n\r\n- [x] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#_add_your_labels)\r\n\r\n---------\r\n\r\nCo-authored-by: Stratoula Kalafateli <[email protected]>","sha":"0cc89457124f9cefbdd08766a7a22b1c4bdcc440"}},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Vadim Kibana <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Partially addresses #191812
SORTcommand.commands.sort.listCommands()commands.sort.getCommand()commands.sort.list()commands.sort.findByPredicate()commands.sort.find()commands.sort.remove()commands.sort.insertIntoCommand()commands.sort.insertExpression()commands.sort.insertCommand()commands, (2)commands.args, (3)commands.options.generic.commands.*generic.commands.args.*generic.commands.options.*Checklist
Delete any items that are not applicable to this PR.
For maintainers