-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Dashboard Usability] Add unsaved filters to app state to url #197313
Draft
rshen91
wants to merge
21
commits into
elastic:main
Choose a base branch
from
rshen91:unsaved-filters
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+135
−41
Draft
Changes from 7 commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
235d658
initial commit
rshen91 f478c91
refactor
rshen91 0e06f75
add test
rshen91 d892a73
Merge remote-tracking branch 'upstream/main' into unsaved-filters
rshen91 4af56b2
fix test
rshen91 12f5d42
Merge remote-tracking branch 'upstream/main' into unsaved-filters
rshen91 9ffd5be
fix
rshen91 3c4ece9
partial refactor
rshen91 7f9638c
Merge remote-tracking branch 'upstream/main' into unsaved-filters
rshen91 4789dd1
Merge remote-tracking branch 'upstream/main' into unsaved-filters
rshen91 0a2c154
recently accessed link in left nav show unsaved changes in new tab
rshen91 3849705
Merge remote-tracking branch 'upstream/main' into unsaved-filters
rshen91 c1b686f
update listing page unit tests
rshen91 c1817a6
fix
rshen91 8034337
Merge remote-tracking branch 'upstream/main' into unsaved-filters
rshen91 61ed436
space id
rshen91 affbc0f
Merge remote-tracking branch 'upstream/main' into unsaved-filters
rshen91 813d7c4
wip
rshen91 c48f074
Merge remote-tracking branch 'upstream/main' into unsaved-filters
rshen91 86ab265
finally working
rshen91 b2baeea
Merge remote-tracking branch 'upstream/main' into unsaved-filters
rshen91 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should unsaved queries also be forwarded to be consistent?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They should be, yes :) I honestly wonder if... all unsaved changes should be forwarded? I can't think of a good argument for why opening a dashboard in a new tab would have different behaviour than the
onClick
behaviour....There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we can re-use the code that generates the share link so they are the same