-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Dashboard/Markdown] Add tabindex #197848
[Dashboard/Markdown] Add tabindex #197848
Conversation
Pinging @elastic/kibana-presentation (Team:Presentation) |
2 similar comments
Pinging @elastic/kibana-presentation (Team:Presentation) |
Pinging @elastic/kibana-presentation (Team:Presentation) |
Looks like the |
81e3b51
to
adff184
Compare
So EDIT: Link to an issue about standardizing markdown across kibana, which I didn't know existed before I tried replacing markdown in this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding tabIndex
LGTM - quick test locally to ensure keyboard interactivity + code review 👍
💚 Build Succeeded
Metrics [docs]Async chunks
History
|
Starting backport for target branches: 8.x |
## Summary This PR adds `tabIndex` to [markdown_vis_controller.tsx](https://github.com/elastic/kibana/compare/main...kowalczyk-krzysztof:kibana:fix/dashboard-markdown-panel?expand=1#diff-47267cf2f7d8f9e72e157ddb40292226a88ad5e51f9c92486799d381c5085e5f). Closes: elastic#186559 ## Visuals: https://github.com/user-attachments/assets/8264c584-e7ca-4647-946a-7b9bd9f7aa8f This video demonstrates the markdown panel being tabbable and the scrollbar in being controlled with keyboard. (cherry picked from commit 6cc8b97)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
# Backport This will backport the following commits from `main` to `8.x`: - [[Dashboard/Markdown] Add tabindex (#197848)](#197848) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Krzysztof Kowalczyk","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-30T15:53:19Z","message":"[Dashboard/Markdown] Add tabindex (#197848)\n\n## Summary\r\n\r\nThis PR adds `tabIndex` to\r\n[markdown_vis_controller.tsx](https://github.com/elastic/kibana/compare/main...kowalczyk-krzysztof:kibana:fix/dashboard-markdown-panel?expand=1#diff-47267cf2f7d8f9e72e157ddb40292226a88ad5e51f9c92486799d381c5085e5f).\r\n\r\nCloses: #186559\r\n\r\n## Visuals:\r\n\r\n\r\nhttps://github.com/user-attachments/assets/8264c584-e7ca-4647-946a-7b9bd9f7aa8f\r\n\r\nThis video demonstrates the markdown panel being tabbable and the\r\nscrollbar in being controlled with keyboard.","sha":"6cc8b97b60e78bf0638fa91b0925eb944133841a","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","Feature:Dashboard","Feature:Markdown","Team:Presentation","loe:small","release_note:skip","impact:medium","v9.0.0","backport:prev-minor"],"title":"[Dashboard/Markdown] Add tabindex","number":197848,"url":"https://github.com/elastic/kibana/pull/197848","mergeCommit":{"message":"[Dashboard/Markdown] Add tabindex (#197848)\n\n## Summary\r\n\r\nThis PR adds `tabIndex` to\r\n[markdown_vis_controller.tsx](https://github.com/elastic/kibana/compare/main...kowalczyk-krzysztof:kibana:fix/dashboard-markdown-panel?expand=1#diff-47267cf2f7d8f9e72e157ddb40292226a88ad5e51f9c92486799d381c5085e5f).\r\n\r\nCloses: #186559\r\n\r\n## Visuals:\r\n\r\n\r\nhttps://github.com/user-attachments/assets/8264c584-e7ca-4647-946a-7b9bd9f7aa8f\r\n\r\nThis video demonstrates the markdown panel being tabbable and the\r\nscrollbar in being controlled with keyboard.","sha":"6cc8b97b60e78bf0638fa91b0925eb944133841a"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/197848","number":197848,"mergeCommit":{"message":"[Dashboard/Markdown] Add tabindex (#197848)\n\n## Summary\r\n\r\nThis PR adds `tabIndex` to\r\n[markdown_vis_controller.tsx](https://github.com/elastic/kibana/compare/main...kowalczyk-krzysztof:kibana:fix/dashboard-markdown-panel?expand=1#diff-47267cf2f7d8f9e72e157ddb40292226a88ad5e51f9c92486799d381c5085e5f).\r\n\r\nCloses: #186559\r\n\r\n## Visuals:\r\n\r\n\r\nhttps://github.com/user-attachments/assets/8264c584-e7ca-4647-946a-7b9bd9f7aa8f\r\n\r\nThis video demonstrates the markdown panel being tabbable and the\r\nscrollbar in being controlled with keyboard.","sha":"6cc8b97b60e78bf0638fa91b0925eb944133841a"}}]}] BACKPORT--> Co-authored-by: Krzysztof Kowalczyk <[email protected]>
Summary
This PR adds
tabIndex
to markdown_vis_controller.tsx.Closes: #186559
Visuals:
chrome_aWPkAz51AM.mp4
This video demonstrates the markdown panel being tabbable and the scrollbar in being controlled with keyboard.