-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[UII] Replace kibanaVersionCheckEnabled
default value instead of config setting
#198172
Conversation
Pinging @elastic/fleet (Team:Fleet) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense to me from the Fleet side of things.
💚 Build Succeeded
Metrics [docs]
History
cc @jen-huang |
capabilities: [], | ||
excludePackages: [], | ||
spec: { | ||
internal: schema.object({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
made this schema object non-optional (removed schema.maybe
wrapper), because the default values do not populate when it is optional, i.e. kibanaVersionCheckEnabled
is undefined
instead of false
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Q: Should this PR be flagged as breaking change
?
@afharo No, we plan on restoring the original behavior after elastic/package-registry#1226 is addressed. |
Summary
This PR removes
xpack.fleet.internal.registry.kibanaVersionCheckEnabled: false
fromkibana.yml
in favor of changing the default value that Fleet populates, so that we do not apply the Kibana version constraint to EPR requests for >= 9.0 deployments.Prior to this change, this setting was not applied to ESS deployments as
kibana.yml
is overridden there.I updated the related task in #192624 to reflect this change.