[8.x] [kbn-test] fix junit report test for local run (#198120) #198254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Summary
When I run test locally with `node scripts/jest --config
packages/kbn-test/jest.config.js`, it fails with
```
FAIL packages/kbn-test/src/mocha/junit_report_generation.test.js
● dev/mocha/junit report generation › reports on failed setup hooks
expect(received).toEqual(expected) // deep equality
- Expected - 1
+ Received + 1
@@ -1,7 +1,7 @@
Object {
- "command-line": "node scripts/jest --config=packages/kbn-test/jest.config.js --runInBand --coverage=false --passWithNoTests",
+ "command-line": "node node_modules/jest-worker/build/workers/processChild.js",
"failures": "2",
"metadata-json": "{}",
"name": "test",
"skipped": "1",
"tests": "4",
```
This PR uses `process.env.CI` as a condition to apply different value
for `command-line` property so test will pass locally too.
(cherry picked from commit ec72eb2)
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
dmlemeshko
approved these changes
Oct 30, 2024
💔 Build Failed
Failed CI StepsTest FailuresMetrics [docs]
Historycc @dmlemeshko |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.x:Questions ?
Please refer to the Backport tool documentation