Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.16] [Synthetics] Fixes partial updates for params and params viewing (#195866) #198284

Open
wants to merge 1 commit into
base: 8.16
Choose a base branch
from
Open

[8.16] [Synthetics] Fixes partial updates for params and params viewing (#195866) #198284

wants to merge 1 commit into from
+355 −110

Commits on Oct 30, 2024

  1. [Synthetics] Fixes partial updates for params and params viewing (ela… 

    …stic#195866)

## Summary

Fixes elastic#167781

In docs we says that only key/value pairs are required, but in actual
edit, that means rest of the data was being lost on edits

Allow partial updates to params edit API !!

This PR makes sure prev objects is fetched and merged with new data
hence allowing partial updates !!

We are also allowing the ability to view value of the secret once it's
saved via API !!

### Value is hidden
Param value will not be visible unless user is `super_user` or
`kibana_admin`, though user can assign new value.

---------

Co-authored-by: Justin Kambic <[email protected]>
(cherry picked from commit 0ff9a8a)
    @shahzad31
    shahzad31 committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    fde40fb View commit details
    Browse the repository at this point in the history