Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SLO] Overview embeddable chart use proper theme !! #198299

Merged
merged 2 commits into from
Oct 30, 2024

Conversation

shahzad31
Copy link
Contributor

@shahzad31 shahzad31 commented Oct 30, 2024

Summary

Fixes #198298

Overview embeddable chart use proper theme !!

After

image

Before

image

@shahzad31 shahzad31 added the backport:prev-major Backport to (8.x, 8.16, 8.15) the previous major branch and all later branches still in development label Oct 30, 2024
@shahzad31 shahzad31 requested a review from a team as a code owner October 30, 2024 11:12
@botelastic botelastic bot added ci:project-deploy-observability Create an Observability project Team:obs-ux-management Observability Management User Experience Team labels Oct 30, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@shahzad31 shahzad31 added the release_note:skip Skip the PR/issue when compiling release notes label Oct 30, 2024
Copy link
Contributor

@mgiota mgiota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@elasticmachine
Copy link
Contributor

elasticmachine commented Oct 30, 2024

💚 Build Succeeded

  • Buildkite Build
  • Commit: 1973d21
  • Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-198299-1973d2166b02

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
slo 855.4KB 855.7KB +264.0B

History

@shahzad31 shahzad31 merged commit 56825f1 into elastic:main Oct 30, 2024
24 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.15, 8.16, 8.x

https://github.com/elastic/kibana/actions/runs/11597476834

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 30, 2024
## Summary

Fixes elastic#198298

Overview embeddable chart use proper theme !!

### After
<img width="1728" alt="image"
src="https://github.com/user-attachments/assets/9fa22277-31ba-41f0-b08a-1ed4d801daff">

### Before

<img width="1728" alt="image"
src="https://github.com/user-attachments/assets/98102df8-6881-4672-9791-9e85f9201c6a">

(cherry picked from commit 56825f1)
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 30, 2024
## Summary

Fixes elastic#198298

Overview embeddable chart use proper theme !!

### After
<img width="1728" alt="image"
src="https://github.com/user-attachments/assets/9fa22277-31ba-41f0-b08a-1ed4d801daff">

### Before

<img width="1728" alt="image"
src="https://github.com/user-attachments/assets/98102df8-6881-4672-9791-9e85f9201c6a">

(cherry picked from commit 56825f1)
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 30, 2024
## Summary

Fixes elastic#198298

Overview embeddable chart use proper theme !!

### After
<img width="1728" alt="image"
src="https://github.com/user-attachments/assets/9fa22277-31ba-41f0-b08a-1ed4d801daff">

### Before

<img width="1728" alt="image"
src="https://github.com/user-attachments/assets/98102df8-6881-4672-9791-9e85f9201c6a">

(cherry picked from commit 56825f1)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.15
8.16
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

@shahzad31 shahzad31 deleted the slo-overview-chart-background branch October 30, 2024 16:35
kibanamachine added a commit that referenced this pull request Oct 30, 2024
…198406)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[SLO] Overview embeddable chart use proper theme !!
(#198299)](#198299)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT
[{"author":{"name":"Shahzad","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-30T16:25:58Z","message":"[SLO]
Overview embeddable chart use proper theme !! (#198299)\n\n##
Summary\r\n\r\nFixes
https://github.com/elastic/kibana/issues/198298\r\n\r\nOverview
embeddable chart use proper theme !!\r\n\r\n### After\r\n<img
width=\"1728\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/9fa22277-31ba-41f0-b08a-1ed4d801daff\">\r\n\r\n\r\n###
Before\r\n\r\n<img width=\"1728\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/98102df8-6881-4672-9791-9e85f9201c6a\">","sha":"56825f19f5570cbd9fff336fa096c18ec23830dd","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-major","ci:project-deploy-observability","Team:obs-ux-management"],"title":"[SLO]
Overview embeddable chart use proper theme
!!","number":198299,"url":"https://github.com/elastic/kibana/pull/198299","mergeCommit":{"message":"[SLO]
Overview embeddable chart use proper theme !! (#198299)\n\n##
Summary\r\n\r\nFixes
https://github.com/elastic/kibana/issues/198298\r\n\r\nOverview
embeddable chart use proper theme !!\r\n\r\n### After\r\n<img
width=\"1728\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/9fa22277-31ba-41f0-b08a-1ed4d801daff\">\r\n\r\n\r\n###
Before\r\n\r\n<img width=\"1728\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/98102df8-6881-4672-9791-9e85f9201c6a\">","sha":"56825f19f5570cbd9fff336fa096c18ec23830dd"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/198299","number":198299,"mergeCommit":{"message":"[SLO]
Overview embeddable chart use proper theme !! (#198299)\n\n##
Summary\r\n\r\nFixes
https://github.com/elastic/kibana/issues/198298\r\n\r\nOverview
embeddable chart use proper theme !!\r\n\r\n### After\r\n<img
width=\"1728\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/9fa22277-31ba-41f0-b08a-1ed4d801daff\">\r\n\r\n\r\n###
Before\r\n\r\n<img width=\"1728\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/98102df8-6881-4672-9791-9e85f9201c6a\">","sha":"56825f19f5570cbd9fff336fa096c18ec23830dd"}}]}]
BACKPORT-->

Co-authored-by: Shahzad <[email protected]>
kibanamachine added a commit that referenced this pull request Oct 30, 2024
…198405)

# Backport

This will backport the following commits from `main` to `8.16`:
- [[SLO] Overview embeddable chart use proper theme !!
(#198299)](#198299)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT
[{"author":{"name":"Shahzad","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-30T16:25:58Z","message":"[SLO]
Overview embeddable chart use proper theme !! (#198299)\n\n##
Summary\r\n\r\nFixes
https://github.com/elastic/kibana/issues/198298\r\n\r\nOverview
embeddable chart use proper theme !!\r\n\r\n### After\r\n<img
width=\"1728\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/9fa22277-31ba-41f0-b08a-1ed4d801daff\">\r\n\r\n\r\n###
Before\r\n\r\n<img width=\"1728\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/98102df8-6881-4672-9791-9e85f9201c6a\">","sha":"56825f19f5570cbd9fff336fa096c18ec23830dd","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-major","ci:project-deploy-observability","Team:obs-ux-management"],"title":"[SLO]
Overview embeddable chart use proper theme
!!","number":198299,"url":"https://github.com/elastic/kibana/pull/198299","mergeCommit":{"message":"[SLO]
Overview embeddable chart use proper theme !! (#198299)\n\n##
Summary\r\n\r\nFixes
https://github.com/elastic/kibana/issues/198298\r\n\r\nOverview
embeddable chart use proper theme !!\r\n\r\n### After\r\n<img
width=\"1728\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/9fa22277-31ba-41f0-b08a-1ed4d801daff\">\r\n\r\n\r\n###
Before\r\n\r\n<img width=\"1728\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/98102df8-6881-4672-9791-9e85f9201c6a\">","sha":"56825f19f5570cbd9fff336fa096c18ec23830dd"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/198299","number":198299,"mergeCommit":{"message":"[SLO]
Overview embeddable chart use proper theme !! (#198299)\n\n##
Summary\r\n\r\nFixes
https://github.com/elastic/kibana/issues/198298\r\n\r\nOverview
embeddable chart use proper theme !!\r\n\r\n### After\r\n<img
width=\"1728\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/9fa22277-31ba-41f0-b08a-1ed4d801daff\">\r\n\r\n\r\n###
Before\r\n\r\n<img width=\"1728\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/98102df8-6881-4672-9791-9e85f9201c6a\">","sha":"56825f19f5570cbd9fff336fa096c18ec23830dd"}}]}]
BACKPORT-->

Co-authored-by: Shahzad <[email protected]>
kibanamachine added a commit that referenced this pull request Oct 30, 2024
…198404)

# Backport

This will backport the following commits from `main` to `8.15`:
- [[SLO] Overview embeddable chart use proper theme !!
(#198299)](#198299)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT
[{"author":{"name":"Shahzad","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-30T16:25:58Z","message":"[SLO]
Overview embeddable chart use proper theme !! (#198299)\n\n##
Summary\r\n\r\nFixes
https://github.com/elastic/kibana/issues/198298\r\n\r\nOverview
embeddable chart use proper theme !!\r\n\r\n### After\r\n<img
width=\"1728\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/9fa22277-31ba-41f0-b08a-1ed4d801daff\">\r\n\r\n\r\n###
Before\r\n\r\n<img width=\"1728\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/98102df8-6881-4672-9791-9e85f9201c6a\">","sha":"56825f19f5570cbd9fff336fa096c18ec23830dd","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-major","ci:project-deploy-observability","Team:obs-ux-management"],"title":"[SLO]
Overview embeddable chart use proper theme
!!","number":198299,"url":"https://github.com/elastic/kibana/pull/198299","mergeCommit":{"message":"[SLO]
Overview embeddable chart use proper theme !! (#198299)\n\n##
Summary\r\n\r\nFixes
https://github.com/elastic/kibana/issues/198298\r\n\r\nOverview
embeddable chart use proper theme !!\r\n\r\n### After\r\n<img
width=\"1728\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/9fa22277-31ba-41f0-b08a-1ed4d801daff\">\r\n\r\n\r\n###
Before\r\n\r\n<img width=\"1728\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/98102df8-6881-4672-9791-9e85f9201c6a\">","sha":"56825f19f5570cbd9fff336fa096c18ec23830dd"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/198299","number":198299,"mergeCommit":{"message":"[SLO]
Overview embeddable chart use proper theme !! (#198299)\n\n##
Summary\r\n\r\nFixes
https://github.com/elastic/kibana/issues/198298\r\n\r\nOverview
embeddable chart use proper theme !!\r\n\r\n### After\r\n<img
width=\"1728\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/9fa22277-31ba-41f0-b08a-1ed4d801daff\">\r\n\r\n\r\n###
Before\r\n\r\n<img width=\"1728\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/98102df8-6881-4672-9791-9e85f9201c6a\">","sha":"56825f19f5570cbd9fff336fa096c18ec23830dd"}}]}]
BACKPORT-->

Co-authored-by: Shahzad <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-major Backport to (8.x, 8.16, 8.15) the previous major branch and all later branches still in development ci:project-deploy-observability Create an Observability project release_note:skip Skip the PR/issue when compiling release notes Team:obs-ux-management Observability Management User Experience Team v8.15.4 v8.16.0 v8.17.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[SLOs] Overview embeddable chart has dark background !!
4 participants