Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.16] [Security Solution][Notes] - fix the notes link that is shown twice in the search bar (#198200) #198366

Merged
merged 3 commits into from
Oct 30, 2024
Merged

[8.16] [Security Solution][Notes] - fix the notes link that is shown twice in the search bar (#198200) #198366

merged 3 commits into from
Oct 30, 2024
+1 −0

Conversation

PhilippeOberti
Copy link
Contributor

Backport

This will backport the following commits from main to 8.16:

Questions ?

Please refer to the Backport tool documentation

\n\n### Questions ?\nPlease refer to the [Backport tool\ndocumentation](https://github.com/sqren/backport)\n\n\n\nCo-authored-by: Philippe Oberti "}}]}] BACKPORT-->

@PhilippeOberti
[Security Solution][Notes] - fix the notes link that is shown twice i…
d589d8c 
…n the search bar (elastic#198200)

## Summary

This PR fixes a minor inconvenience where the Kibana search bar was
showing 2 entries for the new Notes management page.

| Before fix | After fix |
| ------------- | ------------- |
| ![Screenshot 2024-10-29 at 11 53
44 AM](https://github.com/user-attachments/assets/77bd4b5a-d8d4-4f4f-8378-6aff1ec1b00b)
| ![Screenshot 2024-10-29 at 11 53
19 AM](https://github.com/user-attachments/assets/d138e307-b4ea-473b-9102-eb7e7b540bff)
|

Notes: this fix does not fix an issue happening in the space-specific
search, where Notes, Timelines and maybe other entries are appearing
twice. That issue seems to be related to the way we are removing then
adding back links to work with the new navigation. I looked into it but
could not find a way to fix yet, so this will be part of a follow up PR

elastic#197694
(cherry picked from commit ac5c74a)

# Conflicts:
#	x-pack/plugins/security_solution/public/management/links.ts
@PhilippeOberti PhilippeOberti enabled auto-merge (squash) October 30, 2024 14:38
@PhilippeOberti PhilippeOberti mentioned this pull request Oct 30, 2024
Merged
@PhilippeOberti PhilippeOberti merged commit 0f3a0af into elastic:8.16 Oct 30, 2024
35 checks passed
@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #1 / threatMatchRowRenderer #renderRow rendered when indicator matches are more than MAX rendered

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 20.6MB 20.6MB +24.0B

History

@PhilippeOberti PhilippeOberti deleted the backport/8.16/pr-198200 branch October 30, 2024 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janmonschke janmonschke janmonschke approved these changes

Assignees
No one assigned
Labels
backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PhilippeOberti @elasticmachine @janmonschke