Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.x] improve loading UI in Discover mobile (#197939) #198457

Merged
merged 1 commit into from
Oct 31, 2024
+33 −21
Merged

[8.x] improve loading UI in Discover mobile (#197939) #198457

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 29 additions & 15 deletions src/plugins/discover/public/components/common/__snapshots__/loading_indicator.test.tsx.snap
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 4 additions & 6 deletions src/plugins/discover/public/components/common/loading_indicator.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
* License v3.0 only", or the "Server Side Public License, v 1".
*/

import { EuiFlexGroup, EuiFlexItem, EuiLoadingSpinner, EuiLoadingElastic } from '@elastic/eui';
import { EuiEmptyPrompt, EuiLoadingSpinner, EuiLoadingElastic } from '@elastic/eui';
import React from 'react';

interface Props {
Expand All @@ -16,10 +16,8 @@ interface Props {

export const LoadingIndicator = ({ type = 'spinner' }: Props) => {
return (
<EuiFlexGroup justifyContent="spaceAround" alignItems="center" gutterSize="none">
<EuiFlexItem grow={false}>
{type === 'spinner' ? <EuiLoadingSpinner size="l" /> : <EuiLoadingElastic size="xxl" />}
</EuiFlexItem>
</EuiFlexGroup>
<EuiEmptyPrompt
icon={type === 'spinner' ? <EuiLoadingSpinner size="l" /> : <EuiLoadingElastic size="xxl" />}
/>
);
};