Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Cloud Security] Show K8S Dashboard #205149

Merged
merged 6 commits into from
Jan 9, 2025
Merged

[Cloud Security] Show K8S Dashboard #205149

merged 6 commits into from
Jan 9, 2025

Conversation

animehart
Copy link
Contributor

@animehart animehart commented Dec 24, 2024 •
edited
Loading

Summary

As a part of K8S Deprecation process, we only want to Hide K8S Dashboard on Serverless on 8.x . Currently, K8S Dashboard is being hidden on main. This PR enables the K8S Dashboard feature flag and will only target 8.x so that user can still see K8S Dashboard on non-serverless Env for 8.x

the discussion about this decision are shown here

@animehart animehart requested a review from maxcold December 24, 2024 19:25
@animehart
Copy link
Contributor Author

/ci

@animehart animehart marked this pull request as ready for review December 27, 2024 17:16
@animehart animehart added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting Team:Cloud Security Cloud Security team related labels Dec 27, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-cloud-security-posture (Team:Cloud Security)

@animehart animehart requested a review from a team December 27, 2024 18:11
@maxcold
Copy link
Contributor

maxcold commented Jan 7, 2025

@animehart I don't understand this part we only want to Hide K8S Dashboard on Serverless on 8.18.0 of the description. There is no such thing as Serverless on 8.18.0. Serverless is being deployed from main, meaning it's technically pointing to 9.x. If the goal is to hide k8s dashboard in ECH (what we used to refer as ESS) starting from 9.0 and in serverless, but allow it to be shown in 8.x (8.18, 8.19 and so forth) then this PR should allow achieving that

@animehart
Copy link
Contributor Author

@maxcold
Sorry if my wording is confusing,
tldr what we are trying to achieve here is that we want to only show k8s dashboard on 8.x
and will be hidden from 9.0.0 onwards

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

@animehart animehart merged commit 391d4c7 into elastic:8.x Jan 9, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seanrathier seanrathier seanrathier approved these changes

@maxcold maxcold maxcold approved these changes

@kibanamachine kibanamachine Awaiting requested review from kibanamachine kibanamachine is a code owner

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Cloud Security Cloud Security team related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@animehart @elasticmachine @maxcold @seanrathier