Remove jms and hipchat outputs (broken plugins) #408
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reasons: * The jms output cannot be installed under Logstash 5.6 because of a transitive dependency that requires Ruby >=2.1 * The hipchat output cannot be installed under Logstash 5.6 because of a transitive dependency that requires Ruby >=2.0 History here: elastic/logstash#7993 (comment)
|
@jordansissel You'll also need to remove the mention that shows up here: https://www.elastic.co/guide/en/logstash/current/introduction.html Incidentally you didn't catch this with the local build because Deb had to change the link format in order to accommodate translated versions of the getting started content that have only a sub-set of the topics. The full build will return an error for missing links. |
dedemorton
suggested changes
Aug 31, 2017
|
Good catch. I'll file a PR to remove that reference in the logstash docs. |
|
elastic/logstash#8115 removes the reference from the Logstash docs. |
dedemorton
approved these changes
Aug 31, 2017
|
Approved pending merge of elastic/logstash#8115 |
|
Jordan Sissel merged this into the following branches!
|
elasticsearch-bot
pushed a commit
that referenced
this pull request
Aug 31, 2017
Reasons: * The jms output cannot be installed under Logstash 5.6 because of a transitive dependency that requires Ruby >=2.1 * The hipchat output cannot be installed under Logstash 5.6 because of a transitive dependency that requires Ruby >=2.0 History here: elastic/logstash#7993 (comment) Fixes #408
|
Merged; closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ideally we could have the docs sync tool do this task, but it doesn't today :)
This removes the jms and hipchat output plugins per elastic/logstash#7993 (comment)
Docs build seems ok. I checked (with firefox) to see if the jms and hipchat outputs were removed.