Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove deprecated modules netflow, fb_apache and azure #16514

Merged
merged 7 commits into from
Oct 15, 2024

Conversation

kaisecheng
Copy link
Contributor

@kaisecheng kaisecheng commented Oct 7, 2024

Release notes

[rn:skip]

What does this PR do?

removed deprecated modules netflow, fb_apache and azure

Why is it important/What is the impact to the user?

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files (and/or docker env variables)
  • I have added tests that prove my fix is effective or that my feature works

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@kaisecheng kaisecheng marked this pull request as ready for review October 8, 2024 21:30
@kaisecheng
Copy link
Contributor Author

doc has instructions on using modules with netflow as example. The removal of doc will be addressed in another pr.

@yaauie
Copy link
Member

yaauie commented Oct 9, 2024

TODO: companion PR for 8.x that emits an entry on the deprecation logger when either of these deprecated modules is activated.

Looking at the implementation, the best hook for this is likely LogStash::Modules::Scaffold#with_settings, which is only called when the plugin is being activated.

Or possibly by hard-coding a list of them in LogStash::Config::ModulesCommon::pipeline_configs to compare against its lvar specified_and_available_names.

@jsvd jsvd self-assigned this Oct 14, 2024
@kaisecheng kaisecheng requested a review from jsvd October 14, 2024 14:11
@@ -1,99 +0,0 @@
# Module settings and structure
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

given we're not yet removing all modules, maybe we can lead the READMEs intact for now

Copy link
Member

@jsvd jsvd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than maybe restoring the modules/README.md and x-pack/modules/README.md, LGTM

Follow up PRs:

  1. 8.x deprecation entry when these modules are used
  2. main cleanup docs related to netflow, fb_apache and azure modules

@kaisecheng kaisecheng merged commit b571e8f into elastic:main Oct 15, 2024
3 of 5 checks passed
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@elasticmachine
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

History

cc @jsvd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove netflow, fb_apache, azure modules
4 participants