Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport PR #16602 to 8.x: Use jvm catalog for reproducible builds and expose new pipeline to check JDK availability #16609

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

github-actions[bot]
Copy link
Contributor

Backport PR #16602 to 8.x branch, original message:


Release notes

[rn:skip]

What does this PR do?

Updates the existing createElasticCatalogDownloadUrl method to use the precise version retrieved versions.yml to download the JDK instead of using the latest of major version. This makes the build reproducible again.
Defines a new Gradle checkNewJdkVersion task to check if there is a new JDK version available from JVM catalog matching the same major of the current branch.
Creates a new Buildkite pipeline to execute a bash script to run the Gradle task; plus it also update the catalog-info.yaml with the new pipeline and a trigger to execute every week.

Why is it important/What is the impact to the user?

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have made corresponding change to the default configuration files (and/or docker env variables)
  • [ ] I have added tests that prove my fix is effective or that my feature works

Author's Checklist

  • [ ]

How to test this PR locally

  • use the downloadJdk to verify it downloads the version defined versions.yml, for example:
./gradlew clean downloadJdk -Pjdk_bundle_os=linux -Pjdk_arch="x86_64"
  • verify that the new checkNewJdkVersion fails logging a line of a new version availability
./gradlew checkNewJdkVersion

for example:

FAILURE: Build failed with an exception.

* Where:
Build file '/Users/andrea/workspace/logstash_andsel/build.gradle' line: 867

* What went wrong:
A problem occurred configuring root project 'logstash'.
> Could not create task ':checkNewJdkVersion'.
   > New version available for major: 21

Related issues

Use cases

Screenshots

Logs

…eck JDK availability (#16602)

Updates the existing `createElasticCatalogDownloadUrl` method to use the precise version retrieved `versions.yml` to download the JDK instead of using the latest of major version. This makes the build reproducible again.
Defines a new Gradle `checkNewJdkVersion` task to check if there is a new JDK version available from JVM catalog matching the same major of the current branch.
Creates a new Buildkite pipeline to execute a `bash` script to run the Gradle task; plus it also update the `catalog-info.yaml` with the new pipeline and a trigger to execute every week.

(cherry picked from commit ed5874b)
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

@andsel andsel merged commit 51851a9 into 8.x Oct 30, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants