add Java Elastic distribution for Ad and Fraud services #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rogercoll
force-pushed
the
add_java_distribution
branch
from
491b27a
to
2fefde5
Compare
elastic-apm-tech
force-pushed
the
main
branch
3 times, most recently
from
df64111
to
81f0ea1
Compare
rogercoll
force-pushed
the
add_java_distribution
branch
from
c41e903
to
1a4f4c0
Compare
elastic-apm-tech
force-pushed
the
main
branch
2 times, most recently
from
7684417
to
05ad940
Compare
rogercoll
force-pushed
the
add_java_distribution
branch
from
1a4f4c0
to
48e4547
Compare
|
💚 CLA has been signed |
rogercoll
force-pushed
the
add_java_distribution
branch
2 times, most recently
from
fd46d86
to
23d74cd
Compare
rogercoll
changed the title
elastic-apm-tech
force-pushed
the
main
branch
2 times, most recently
from
c86cdc0
to
af6fa16
Compare
rogercoll
force-pushed
the
add_java_distribution
branch
from
23d74cd
to
719b57a
Compare
rogercoll
commented
Jun 7, 2024
Comment on lines
+19
to
+25
| ARG version=0.3.2 | ||
| WORKDIR /usr/src/app/ | ||
|
|
||
| COPY --from=builder /usr/src/app/ ./ | ||
| ADD --chmod=644 https://repo1.maven.org/maven2/co/elastic/otel/elastic-otel-javaagent/$version/elastic-otel-javaagent-$version.jar /usr/src/app/opentelemetry-javaagent.jar | ||
| ENV JAVA_TOOL_OPTIONS=-javaagent:/usr/src/app/opentelemetry-javaagent.jar | ||
| ENV ELASTIC_OTEL_INFERRED_SPANS_ENABLED=true |
There was a problem hiding this comment.
Gathers and includes the Java Agent distribution
There was a problem hiding this comment.
In the future we might have a docker image you could just copy from, which makes the update process even easier as dependabot can handle it.
SylvainJuge
approved these changes
Jun 7, 2024
Comment on lines
+19
to
+25
| ARG version=0.3.2 | ||
| WORKDIR /usr/src/app/ | ||
|
|
||
| COPY --from=builder /usr/src/app/ ./ | ||
| ADD --chmod=644 https://repo1.maven.org/maven2/co/elastic/otel/elastic-otel-javaagent/$version/elastic-otel-javaagent-$version.jar /usr/src/app/opentelemetry-javaagent.jar | ||
| ENV JAVA_TOOL_OPTIONS=-javaagent:/usr/src/app/opentelemetry-javaagent.jar | ||
| ENV ELASTIC_OTEL_INFERRED_SPANS_ENABLED=true |
There was a problem hiding this comment.
In the future we might have a docker image you could just copy from, which makes the update process even easier as dependabot can handle it.
rogercoll
force-pushed
the
add_java_distribution
branch
from
719b57a
to
816c758
Compare
ChrsMark
approved these changes
Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Add Elastic Dockerfiles (Dockerfile.elastic) that uses the Elastic's Java agent distribution for the Ad and Fraud detection services. Those Dockerfiles are a copy of the upstream version but replacing the Java agent.
The idea is to later parametrize the
Dockerfilefile used in thedocker-compose.ymlto point to our custom Dockerfile using the new .env.override file.Alternatives
Merge Requirements
For new features contributions please make sure you have completed the following
essential items:
CHANGELOG.mdupdated to document new feature additionsMaintainers will not merge until the above have been completed. If you're unsure
which docs need to be changed ping the
@open-telemetry/demo-approvers.