forked from open-telemetry/opentelemetry-demo
-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: build and publish custom Elastic images #18
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rogercoll
force-pushed
the
build_elastic_images
branch
from
June 5, 2024 09:07
0033a92
to
0baf4a6
Compare
elastic-apm-tech
force-pushed
the
main
branch
6 times, most recently
from
June 10, 2024 18:30
bb22d3e
to
4b42c76
Compare
rogercoll
force-pushed
the
build_elastic_images
branch
from
June 12, 2024 12:25
0baf4a6
to
1dfebfe
Compare
rogercoll
force-pushed
the
build_elastic_images
branch
2 times, most recently
from
June 13, 2024 13:09
cf8ca69
to
11466ba
Compare
elastic-apm-tech
force-pushed
the
main
branch
2 times, most recently
from
June 14, 2024 06:30
4eea166
to
4d841ca
Compare
rogercoll
force-pushed
the
build_elastic_images
branch
from
June 18, 2024 07:10
11466ba
to
34293c8
Compare
ChrsMark
approved these changes
Jun 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
elastic-apm-tech
pushed a commit
that referenced
this pull request
Jun 18, 2024
* ci: build and publish custom Elastic images * ci: use Elastic Dockerfile for adservice * ci: add release file * ci: remove on push trigger * ci: add workflow to test image generation on push
elastic-apm-tech
pushed a commit
that referenced
this pull request
Jun 18, 2024
* ci: build and publish custom Elastic images * ci: use Elastic Dockerfile for adservice * ci: add release file * ci: remove on push trigger * ci: add workflow to test image generation on push
elastic-apm-tech
pushed a commit
that referenced
this pull request
Jun 19, 2024
* ci: build and publish custom Elastic images * ci: use Elastic Dockerfile for adservice * ci: add release file * ci: remove on push trigger * ci: add workflow to test image generation on push
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Adds a GitHub action to publish our custom services images. The action will be triggered on each release. The workflow files are a copy of the upstream repository but pointing to the Elastic's dockerfiles and removing Dockerhub registry. Initially, we would be publishing the images to the repository Github image registry.
Merge Requirements
For new features contributions please make sure you have completed the following
essential items:
CHANGELOG.md
updated to document new feature additionsMaintainers will not merge until the above have been completed. If you're unsure
which docs need to be changed ping the
@open-telemetry/demo-approvers.