Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand AI Assistant query advice #4294

Merged
merged 10 commits into from
Nov 30, 2023
Merged

Expand AI Assistant query advice #4294

merged 10 commits into from
Nov 30, 2023

Conversation

benironside
Copy link
Contributor

@benironside benironside commented Nov 16, 2023

Fixes #4293

Preview: Elastic AI Asssistant

@benironside benironside self-assigned this Nov 16, 2023
@benironside benironside added Feature: Elastic AI Assistant Interface for interacting with generative AIs v8.11.0 labels Nov 16, 2023
Copy link

Documentation previews:

@benironside benironside requested a review from dhru42 November 16, 2023 17:29
@dhru42 dhru42 marked this pull request as ready for review November 16, 2023 18:15
@dhru42 dhru42 requested a review from a team as a code owner November 16, 2023 18:15
dhru42
dhru42 previously approved these changes Nov 29, 2023
Copy link
Collaborator

@dhru42 dhru42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

Copy link
Contributor

@natasha-moore-elastic natasha-moore-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some minor suggestions, otherwise looks good!

docs/assistant/security-assistant.asciidoc Outdated Show resolved Hide resolved
docs/assistant/security-assistant.asciidoc Outdated Show resolved Hide resolved
docs/assistant/security-assistant.asciidoc Outdated Show resolved Hide resolved
Copy link
Contributor

@joepeeples joepeeples left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a few suggestions, thanks!

docs/assistant/images/knowledge-base-dialogue.png Outdated Show resolved Hide resolved
docs/assistant/security-assistant.asciidoc Outdated Show resolved Hide resolved
docs/assistant/security-assistant.asciidoc Outdated Show resolved Hide resolved
docs/assistant/security-assistant.asciidoc Outdated Show resolved Hide resolved
@benironside benironside requested a review from a team November 29, 2023 20:05
Copy link
Contributor

@nastasha-solomon nastasha-solomon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving so this PR can be merged.

@benironside benironside merged commit b37854d into main Nov 30, 2023
1 check passed
mergify bot pushed a commit that referenced this pull request Nov 30, 2023
* first pass at incorporating Dhru's input

* incorporates edits

* Update docs/assistant/security-assistant.asciidoc

Co-authored-by: natasha-moore-elastic <[email protected]>

* Update docs/assistant/security-assistant.asciidoc

Co-authored-by: natasha-moore-elastic <[email protected]>

* incorporates feedback

* Update docs/assistant/security-assistant.asciidoc

Co-authored-by: Joe Peeples <[email protected]>

---------

Co-authored-by: natasha-moore-elastic <[email protected]>
Co-authored-by: Joe Peeples <[email protected]>
(cherry picked from commit b37854d)
benironside added a commit that referenced this pull request Nov 30, 2023
* first pass at incorporating Dhru's input

* incorporates edits

* Update docs/assistant/security-assistant.asciidoc

Co-authored-by: natasha-moore-elastic <[email protected]>

* Update docs/assistant/security-assistant.asciidoc

Co-authored-by: natasha-moore-elastic <[email protected]>

* incorporates feedback

* Update docs/assistant/security-assistant.asciidoc

Co-authored-by: Joe Peeples <[email protected]>

---------

Co-authored-by: natasha-moore-elastic <[email protected]>
Co-authored-by: Joe Peeples <[email protected]>
(cherry picked from commit b37854d)

Co-authored-by: Benjamin Ironside Goldstein <[email protected]>
@joepeeples joepeeples deleted the 4293-AI-KB-expand branch December 1, 2023 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature: Elastic AI Assistant Interface for interacting with generative AIs v8.11.0
Projects
Development

Successfully merging this pull request may close these issues.

Expand AI Assistant Knowledge base example
6 participants