Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CIS GCP] Notify the user about cloud shell editor deprecation #5031

Merged
merged 8 commits into from
Apr 15, 2024

Conversation

uri-weisman
Copy link
Contributor

Update the GCP onboarding docs to notify our users about the GCP Cloudshell editor deprecation.
This change may confuse users who will install our integration using the deployment manager.

Slack discussion: https://elastic.slack.com/archives/C03E5KGNWT1/p1708447923318629

Copy link

github-actions bot commented Apr 3, 2024

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

Copy link
Contributor

mergify bot commented Apr 3, 2024

This pull request does not have a backport label. Could you fix it @uri-weisman? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • v7.x is the label to automatically backport to the 7.x branch.
  • v7./d./d is the label to automatically backport to the 7./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip label Apr 3, 2024
@uri-weisman
Copy link
Contributor Author

@uri-weisman uri-weisman marked this pull request as ready for review April 3, 2024 06:52
@uri-weisman uri-weisman requested a review from a team as a code owner April 3, 2024 06:52
@benironside benironside self-assigned this Apr 10, 2024
@benironside benironside added v8.12.0 v8.14.0 Team: Cloud Security AWP + Cloud Security Posture labels Apr 15, 2024
Copy link
Contributor

@nastasha-solomon nastasha-solomon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just have one more to add to Joe's edit.

docs/cloud-native-security/cspm-get-started-gcp.asciidoc Outdated Show resolved Hide resolved
Copy link
Contributor

@jmikell821 jmikell821 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merged feedback LGTM!

@benironside benironside merged commit efe4d12 into main Apr 15, 2024
3 checks passed
mergify bot pushed a commit that referenced this pull request Apr 15, 2024
* Update cspm-get-started-gcp.asciidoc

* add image

* minor edits

* Update docs/cloud-native-security/cspm-get-started-gcp.asciidoc

Co-authored-by: Joe Peeples <[email protected]>

* Update docs/cloud-native-security/cspm-get-started-gcp.asciidoc

Co-authored-by: Joe Peeples <[email protected]>

* Update docs/cloud-native-security/cspm-get-started-gcp.asciidoc

---------

Co-authored-by: Benjamin Ironside Goldstein <[email protected]>
Co-authored-by: Benjamin Ironside Goldstein <[email protected]>
Co-authored-by: Joe Peeples <[email protected]>
(cherry picked from commit efe4d12)
mergify bot pushed a commit that referenced this pull request Apr 15, 2024
* Update cspm-get-started-gcp.asciidoc

* add image

* minor edits

* Update docs/cloud-native-security/cspm-get-started-gcp.asciidoc

Co-authored-by: Joe Peeples <[email protected]>

* Update docs/cloud-native-security/cspm-get-started-gcp.asciidoc

Co-authored-by: Joe Peeples <[email protected]>

* Update docs/cloud-native-security/cspm-get-started-gcp.asciidoc

---------

Co-authored-by: Benjamin Ironside Goldstein <[email protected]>
Co-authored-by: Benjamin Ironside Goldstein <[email protected]>
Co-authored-by: Joe Peeples <[email protected]>
(cherry picked from commit efe4d12)
benironside pushed a commit that referenced this pull request Apr 15, 2024
#5092)

* Update cspm-get-started-gcp.asciidoc

* add image

* minor edits

* Update docs/cloud-native-security/cspm-get-started-gcp.asciidoc

Co-authored-by: Joe Peeples <[email protected]>

* Update docs/cloud-native-security/cspm-get-started-gcp.asciidoc

Co-authored-by: Joe Peeples <[email protected]>

* Update docs/cloud-native-security/cspm-get-started-gcp.asciidoc

---------

Co-authored-by: Benjamin Ironside Goldstein <[email protected]>
Co-authored-by: Benjamin Ironside Goldstein <[email protected]>
Co-authored-by: Joe Peeples <[email protected]>
(cherry picked from commit efe4d12)

Co-authored-by: Uri Weisman <[email protected]>
benironside pushed a commit that referenced this pull request Apr 15, 2024
#5093)

* Update cspm-get-started-gcp.asciidoc

* add image

* minor edits

* Update docs/cloud-native-security/cspm-get-started-gcp.asciidoc

Co-authored-by: Joe Peeples <[email protected]>

* Update docs/cloud-native-security/cspm-get-started-gcp.asciidoc

Co-authored-by: Joe Peeples <[email protected]>

* Update docs/cloud-native-security/cspm-get-started-gcp.asciidoc

---------

Co-authored-by: Benjamin Ironside Goldstein <[email protected]>
Co-authored-by: Benjamin Ironside Goldstein <[email protected]>
Co-authored-by: Joe Peeples <[email protected]>
(cherry picked from commit efe4d12)

Co-authored-by: Uri Weisman <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants