Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ESS][8.14] ES|QL rule is GA'ing #5032

Merged
merged 14 commits into from
May 6, 2024

Conversation

vitaliidm
Copy link
Contributor

@vitaliidm vitaliidm commented Apr 3, 2024

Copy link

github-actions bot commented Apr 3, 2024

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

Copy link
Contributor

mergify bot commented Apr 3, 2024

This pull request is now in conflicts. Could you fix it @vitaliidm? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b remove-tech-preview-esql upstream/remove-tech-preview-esql
git merge upstream/main
git push upstream remove-tech-preview-esql

@vitaliidm
Copy link
Contributor Author

Kibana PR has been merged: elastic/kibana#179855

@nastasha-solomon nastasha-solomon added Priority: High Issues that are time-sensitive and/or are of high customer importance Effort: Small Issues that can be resolved quickly labels Apr 10, 2024
Copy link
Contributor

@nastasha-solomon nastasha-solomon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updating this comment:

  • Tech preview label removed from all ES|QL feature docs ✅
  • Note about enabling/disabling the ES|QL Timeline tab has been removed ✅

@michaelolo24 the only thing that's left is for me to refresh the screenshot of the ES|QL tab in Timeline. Right now, it has the tech preview icon and the banner notifying users that ES|QL is still in technical preview.

esql-tab

@nastasha-solomon nastasha-solomon linked an issue Apr 10, 2024 that may be closed by this pull request
@nastasha-solomon nastasha-solomon self-assigned this Apr 10, 2024
@michaelolo24
Copy link

Updating this comment:

  • Tech preview label removed from all ES|QL feature docs ✅
  • Note about enabling/disabling the ES|QL Timeline tab has been removed ✅

@michaelolo24 the only thing that's left is for me to refresh the screenshot of the ES|QL tab in Timeline. Right now, it has the tech preview icon and the banner notifying users that ES|QL is still in technical preview.

esql-tab

Will get you an updated screenshot asap!

@michaelolo24
Copy link

michaelolo24 commented Apr 16, 2024

Thanks for making the changes @vitaliidm ! The PR removing the technical preview tag from the tab is here:

elastic/kibana#180838

michaelolo24
michaelolo24 previously approved these changes Apr 16, 2024
@nastasha-solomon nastasha-solomon changed the title [Detection Engine] removes tech preview from ES|QL rule type [ESS][8.14] Removes tech preview label from ES|QL docs Apr 16, 2024
michaelolo24 added a commit to elastic/kibana that referenced this pull request Apr 16, 2024
## Summary

This PR removes the technical preview tag from the ES|QL tab in timeline
in preparation for GA in 8.14. [Related docs
pr](elastic/security-docs#5032)

Before:

<img width="1269" alt="image"
src="https://github.com/elastic/kibana/assets/17211684/33c9c328-ad0b-40f2-b5de-32165aecabbf">


After: 


![image](https://github.com/elastic/kibana/assets/17211684/6f241276-81fd-46d5-99ba-6fdb679ac383)



### Checklist
- [x]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
@nastasha-solomon
Copy link
Contributor

Moving this PR back to the draft state as I make additional updates to screenshots and AI assistant docs.

@nastasha-solomon nastasha-solomon marked this pull request as draft April 16, 2024 15:54
@nastasha-solomon nastasha-solomon dismissed stale reviews from michaelolo24 and themself via 5662aa7 April 30, 2024 01:21
@nastasha-solomon nastasha-solomon changed the title [ESS][8.14] Removes tech preview label from ES|QL docs [ESS][8.14] Removes tech preview label from ES|QL rule docs Apr 30, 2024
@nastasha-solomon nastasha-solomon marked this pull request as ready for review April 30, 2024 01:24
@nastasha-solomon nastasha-solomon self-requested a review April 30, 2024 01:24
@nastasha-solomon
Copy link
Contributor

@michaelolo24 heads up that I'm moving the Timeline-related changes over to #5139.

@nastasha-solomon nastasha-solomon requested review from a team and removed request for nastasha-solomon April 30, 2024 14:04
@nastasha-solomon nastasha-solomon marked this pull request as draft May 5, 2024 14:09
@nastasha-solomon nastasha-solomon changed the title [ESS][8.14] Removes tech preview label from ES|QL rule docs [ESS][8.14] ES|QL rule is GA'ing May 6, 2024
@nastasha-solomon nastasha-solomon marked this pull request as ready for review May 6, 2024 20:47
@nastasha-solomon nastasha-solomon requested a review from a team May 6, 2024 20:48
Copy link
Contributor

@benironside benironside left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@nastasha-solomon nastasha-solomon merged commit 2a33b91 into elastic:main May 6, 2024
3 checks passed
mergify bot pushed a commit that referenced this pull request May 6, 2024
* [Detection Engine] removes tech preview from ES|QL rule type

* Removing additional preview labels

* Removes note about FF

* Re-adding Timeline content

Keeping this PR to rule-related changes only

* Moving para to correct place

---------

Co-authored-by: nastasha.solomon <[email protected]>
Co-authored-by: Nastasha Solomon <[email protected]>
(cherry picked from commit 2a33b91)
nastasha-solomon pushed a commit that referenced this pull request May 6, 2024
* [Detection Engine] removes tech preview from ES|QL rule type

* Removing additional preview labels

* Removes note about FF

* Re-adding Timeline content

Keeping this PR to rule-related changes only

* Moving para to correct place

---------

Co-authored-by: nastasha.solomon <[email protected]>
Co-authored-by: Nastasha Solomon <[email protected]>
(cherry picked from commit 2a33b91)

Co-authored-by: Vitalii Dmyterko <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Effort: Small Issues that can be resolved quickly Priority: High Issues that are time-sensitive and/or are of high customer importance Team: Detection Engine v8.14.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Request][ESS] [ES|QL] Update rule type to GA
4 participants