Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds refresh field to value list API docs #5119

Merged
merged 5 commits into from
Apr 26, 2024

Conversation

natasha-moore-elastic
Copy link
Contributor

@natasha-moore-elastic natasha-moore-elastic commented Apr 24, 2024

@natasha-moore-elastic natasha-moore-elastic added API Feature: Exceptions Team: Detection Engine Priority: Medium Issues that have relevance, but aren't urgent Effort: Medium Issues that take moderate but not substantial time to complete Docset: ESS Issues that apply to docs in the Stack release v8.14.0 labels Apr 24, 2024
@natasha-moore-elastic natasha-moore-elastic self-assigned this Apr 24, 2024
@natasha-moore-elastic natasha-moore-elastic changed the title Adds refresh field to value list API docs Adds refresh field to value list API docs Apr 24, 2024
Copy link

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

@natasha-moore-elastic natasha-moore-elastic marked this pull request as ready for review April 24, 2024 12:37
@natasha-moore-elastic natasha-moore-elastic requested a review from a team as a code owner April 24, 2024 12:37
nkhristinin
nkhristinin previously approved these changes Apr 24, 2024
Copy link
Contributor

@nastasha-solomon nastasha-solomon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good - thanks for picking this up, @natasha-moore-elastic!

docs/detections/api/lists/api-delete-list-item.asciidoc Outdated Show resolved Hide resolved
benironside
benironside previously approved these changes Apr 24, 2024
Copy link
Contributor

@benironside benironside left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, made one small suggestion that applies in a few places

docs/detections/api/lists/api-create-list-item.asciidoc Outdated Show resolved Hide resolved
docs/detections/api/lists/api-delete-list-item.asciidoc Outdated Show resolved Hide resolved
docs/detections/api/lists/api-import-list-items.asciidoc Outdated Show resolved Hide resolved
docs/detections/api/lists/api-update-list-item.asciidoc Outdated Show resolved Hide resolved
Co-authored-by: Benjamin Ironside Goldstein <[email protected]>
@natasha-moore-elastic natasha-moore-elastic merged commit cf5bd47 into main Apr 26, 2024
3 checks passed
mergify bot pushed a commit that referenced this pull request Apr 26, 2024
* Adds refresh field to value list API docs

* Update docs/detections/api/lists/api-delete-list-item.asciidoc

Co-authored-by: Nastasha Solomon <[email protected]>

* Apply suggestions from code review

Co-authored-by: Benjamin Ironside Goldstein <[email protected]>

* Update docs/detections/api/lists/api-delete-list-item.asciidoc

---------

Co-authored-by: Nastasha Solomon <[email protected]>
Co-authored-by: Benjamin Ironside Goldstein <[email protected]>
(cherry picked from commit cf5bd47)
natasha-moore-elastic added a commit that referenced this pull request Apr 26, 2024
* Adds refresh field to value list API docs

* Update docs/detections/api/lists/api-delete-list-item.asciidoc

Co-authored-by: Nastasha Solomon <[email protected]>

* Apply suggestions from code review

Co-authored-by: Benjamin Ironside Goldstein <[email protected]>

* Update docs/detections/api/lists/api-delete-list-item.asciidoc

---------

Co-authored-by: Nastasha Solomon <[email protected]>
Co-authored-by: Benjamin Ironside Goldstein <[email protected]>
(cherry picked from commit cf5bd47)

Co-authored-by: natasha-moore-elastic <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Docset: ESS Issues that apply to docs in the Stack release Effort: Medium Issues that take moderate but not substantial time to complete Feature: Exceptions Priority: Medium Issues that have relevance, but aren't urgent Team: Detection Engine v8.14.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Update Value list API docs with refresh field
5 participants