Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deletes extraneous setup guide notes #5184

Merged
merged 1 commit into from
May 8, 2024

Conversation

dplumlee
Copy link
Contributor

@dplumlee dplumlee commented May 8, 2024

Removes remaining setup guide notes and labels that were accidentally not included in #5095

@dplumlee dplumlee self-assigned this May 8, 2024
@dplumlee dplumlee requested a review from a team as a code owner May 8, 2024 15:40
Copy link

github-actions bot commented May 8, 2024

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

Copy link
Contributor

mergify bot commented May 8, 2024

This pull request does not have a backport label. Could you fix it @dplumlee? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • v7.x is the label to automatically backport to the 7.x branch.
  • v7./d./d is the label to automatically backport to the 7./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip label May 8, 2024
@dplumlee dplumlee added Team: Detections/Response Detections and Response API Feature: Rules Docset: ESS Issues that apply to docs in the Stack release v8.14.0 v8.15.0 and removed backport-skip labels May 8, 2024
Copy link
Contributor

@nastasha-solomon nastasha-solomon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes lgtm!

@nastasha-solomon nastasha-solomon merged commit 33eab9c into main May 8, 2024
4 checks passed
mergify bot pushed a commit that referenced this pull request May 8, 2024
nastasha-solomon pushed a commit that referenced this pull request May 8, 2024
(cherry picked from commit 33eab9c)

Co-authored-by: Davis Plumlee <[email protected]>
@nastasha-solomon nastasha-solomon deleted the setup-guide-forgotten-ommisions branch May 8, 2024 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Docset: ESS Issues that apply to docs in the Stack release Feature: Rules Team: Detections/Response Detections and Response v8.14.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants