-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Endpoint system requirements #5271
Conversation
A documentation preview will be available soon. Request a new doc build by commenting
If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here. |
🚀 Built co-preview-docs successfully!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not incorrect, but the table format used this way seems a little unexpected because it could only ever have one single row. I think rotating the table, so the left column has types of info and the right column has their values, is more typical, like this example.
I agree, @joepeeples – I tried to do that initially, and it works for ESS docs, but we don't seem to support headerless tables in serverless docs (I tried both regular MD syntax and the |
@roxana-gheorghe, just to double-check, is there any information that we should add before the table (similar to what we have here)? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
* Endpoint system requirements * Reformats table (cherry picked from commit 272fc61) # Conflicts: # docs/serverless/edr-install-config/deploy-endpoint-reqs.mdx
* Endpoint system requirements * Reformats table (cherry picked from commit 272fc61) # Conflicts: # docs/serverless/edr-install-config/deploy-endpoint-reqs.mdx
* Endpoint system requirements (#5271) * Endpoint system requirements * Reformats table (cherry picked from commit 272fc61) # Conflicts: # docs/serverless/edr-install-config/deploy-endpoint-reqs.mdx * Delete docs/serverless directory and its contents * Revert "Delete docs/serverless directory and its contents" This reverts commit 9306bb5. * Removes serverless folder --------- Co-authored-by: natasha-moore-elastic <[email protected]> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: natasha-moore-elastic <[email protected]>
* Endpoint system requirements (#5271) * Endpoint system requirements * Reformats table (cherry picked from commit 272fc61) # Conflicts: # docs/serverless/edr-install-config/deploy-endpoint-reqs.mdx * Delete docs/serverless directory and its contents * Revert "Delete docs/serverless directory and its contents" This reverts commit 0573923. * Removes serverless folder --------- Co-authored-by: natasha-moore-elastic <[email protected]> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: natasha-moore-elastic <[email protected]>
Resolves #4636. Adds Endpoint system requirements to ESS and serverless docs.
Previews: