Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ESS & Serverless] Adds OrganizationUnitIDs description to agentless section of AWS CSPM guide #6155

Merged
merged 2 commits into from
Nov 20, 2024

Conversation

benironside
Copy link
Contributor

@benironside benironside commented Nov 13, 2024

Fixes #5636
Adds OrganizationalUnitIDs field to the agentless CSPM AWS guides, edits the field's description in agent-based method.

Preview: CSPM for AWS (ESS), (Serverless)

Copy link

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

@benironside benironside assigned eyalkraft and unassigned eyalkraft Nov 14, 2024
@acorretti acorretti force-pushed the 5636-organizationUnitIDs-cspm branch from eb4a6ea to 72d0b44 Compare November 19, 2024 18:23
Copy link
Contributor

mergify bot commented Nov 19, 2024

This pull request is now in conflicts. Could you fix it @benironside? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b 5636-organizationUnitIDs-cspm upstream/5636-organizationUnitIDs-cspm
git merge upstream/main
git push upstream 5636-organizationUnitIDs-cspm

…ts language for the field in agent-based method
@benironside benironside force-pushed the 5636-organizationUnitIDs-cspm branch from 72d0b44 to 9b7c6a2 Compare November 19, 2024 19:24
@benironside benironside marked this pull request as ready for review November 19, 2024 20:37
@benironside benironside requested a review from a team as a code owner November 19, 2024 20:37
Copy link
Contributor

@nastasha-solomon nastasha-solomon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just two small edits!

smriti0321
smriti0321 previously approved these changes Nov 20, 2024
Copy link

@smriti0321 smriti0321 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Co-authored-by: Nastasha Solomon <[email protected]>
Copy link
Contributor

@nastasha-solomon nastasha-solomon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢🚢🚢

@benironside benironside merged commit ed8b9bb into main Nov 20, 2024
3 checks passed
mergify bot pushed a commit that referenced this pull request Nov 20, 2024
…section of AWS CSPM guide (#6155)

* Adds OrganizationalUnitIDs field to the agentless CSPM AWS guide, edits language for the field in agent-based method

* Apply suggestions from code review

Co-authored-by: Nastasha Solomon <[email protected]>

---------

Co-authored-by: Nastasha Solomon <[email protected]>
(cherry picked from commit ed8b9bb)

# Conflicts:
#	docs/serverless/cloud-native-security/cspm-get-started.asciidoc
mergify bot pushed a commit that referenced this pull request Nov 20, 2024
…section of AWS CSPM guide (#6155)

* Adds OrganizationalUnitIDs field to the agentless CSPM AWS guide, edits language for the field in agent-based method

* Apply suggestions from code review

Co-authored-by: Nastasha Solomon <[email protected]>

---------

Co-authored-by: Nastasha Solomon <[email protected]>
(cherry picked from commit ed8b9bb)

# Conflicts:
#	docs/serverless/cloud-native-security/cspm-get-started.asciidoc
benironside added a commit that referenced this pull request Nov 20, 2024
…ntless section of AWS CSPM guide (backport #6155) (#6195)

* [ESS & Serverless] Adds OrganizationUnitIDs description to agentless section of AWS CSPM guide (#6155)

* Adds OrganizationalUnitIDs field to the agentless CSPM AWS guide, edits language for the field in agent-based method

* Apply suggestions from code review

Co-authored-by: Nastasha Solomon <[email protected]>

---------

Co-authored-by: Nastasha Solomon <[email protected]>
(cherry picked from commit ed8b9bb)

# Conflicts:
#	docs/serverless/cloud-native-security/cspm-get-started.asciidoc

* Delete docs/serverless directory and its contents

---------

Co-authored-by: Benjamin Ironside Goldstein <[email protected]>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
benironside added a commit that referenced this pull request Nov 20, 2024
…tless section of AWS CSPM guide (backport #6155) (#6193)

* [ESS & Serverless] Adds OrganizationUnitIDs description to agentless section of AWS CSPM guide (#6155)

* Adds OrganizationalUnitIDs field to the agentless CSPM AWS guide, edits language for the field in agent-based method

* Apply suggestions from code review

Co-authored-by: Nastasha Solomon <[email protected]>

---------

Co-authored-by: Nastasha Solomon <[email protected]>
(cherry picked from commit ed8b9bb)

# Conflicts:
#	docs/serverless/cloud-native-security/cspm-get-started.asciidoc

* Delete docs/serverless directory and its contents

---------

Co-authored-by: Benjamin Ironside Goldstein <[email protected]>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[enhancement] CSPM onboarding "Organization
4 participants