Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BYO LLM Image Update #6368

Merged
merged 3 commits into from
Dec 19, 2024
Merged

BYO LLM Image Update #6368

merged 3 commits into from
Dec 19, 2024

Conversation

benironside
Copy link
Contributor

@benironside benironside commented Dec 18, 2024 •
edited
Loading

Fixes #6276 by updating an outdated image in the BYO LLM guide.

Preview: ESS, serverless

@benironside benironside self-assigned this Dec 18, 2024
@benironside benironside requested a review from a team as a code owner December 18, 2024 20:54
@github-actions GitHub Actions
Copy link

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 18, 2024

This pull request is now in conflicts. Could you fix it @benironside? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b 6276-update-image-byo-llm upstream/6276-update-image-byo-llm
git merge upstream/main
git push upstream 6276-update-image-byo-llm

jmikell821
jmikell821 previously approved these changes Dec 18, 2024
View reviewed changes
Copy link
Contributor

@jmikell821 jmikell821 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left an alt suggestion, but will approve.

docs/AI-for-security/connect-to-byo.asciidoc Outdated Show resolved Hide resolved
@benironside benironside enabled auto-merge (squash) December 19, 2024 20:41
@benironside benironside merged commit f8eb92a into main Dec 19, 2024
4 checks passed
mergify bot pushed a commit that referenced this pull request Dec 19, 2024
@benironside @mergify
BYO LLM Image Update (#6368)
19aeca0 
* BYO LLM Image Update

* incorporates Janeen's review

(cherry picked from commit f8eb92a)

# Conflicts:
#	docs/serverless/AI-for-security/connect-to-byo-llm.asciidoc
#	docs/serverless/AI-for-security/images/lms-studio-model-loaded-msg.png
@mergify mergify bot mentioned this pull request Dec 19, 2024
Merged
mergify bot pushed a commit that referenced this pull request Dec 19, 2024
@benironside @mergify
BYO LLM Image Update (#6368)
028f8a4 
* BYO LLM Image Update

* incorporates Janeen's review

(cherry picked from commit f8eb92a)

# Conflicts:
#	docs/serverless/AI-for-security/connect-to-byo-llm.asciidoc
#	docs/serverless/AI-for-security/images/lms-studio-model-loaded-msg.png
mergify bot pushed a commit that referenced this pull request Dec 19, 2024
@benironside @mergify
BYO LLM Image Update (#6368)
5028d36 
* BYO LLM Image Update

* incorporates Janeen's review

(cherry picked from commit f8eb92a)

# Conflicts:
#	docs/serverless/AI-for-security/connect-to-byo-llm.asciidoc
#	docs/serverless/AI-for-security/images/lms-studio-model-loaded-msg.png
This was referenced Dec 19, 2024
Merged
Merged
nastasha-solomon pushed a commit that referenced this pull request Dec 19, 2024
@mergify @benironside @github-actions
[8.17] BYO LLM Image Update (backport #6368) (#6379)
9deb36c 
* BYO LLM Image Update (#6368)

* BYO LLM Image Update

* incorporates Janeen's review

(cherry picked from commit f8eb92a)

# Conflicts:
#	docs/serverless/AI-for-security/connect-to-byo-llm.asciidoc
#	docs/serverless/AI-for-security/images/lms-studio-model-loaded-msg.png

* Delete docs/serverless directory and its contents

---------

Co-authored-by: Benjamin Ironside Goldstein <[email protected]>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
nastasha-solomon pushed a commit that referenced this pull request Dec 19, 2024
@mergify @benironside @github-actions
[8.16] BYO LLM Image Update (backport #6368) (#6380)
3015325 
* BYO LLM Image Update (#6368)

* BYO LLM Image Update

* incorporates Janeen's review

(cherry picked from commit f8eb92a)

# Conflicts:
#	docs/serverless/AI-for-security/connect-to-byo-llm.asciidoc
#	docs/serverless/AI-for-security/images/lms-studio-model-loaded-msg.png

* Delete docs/serverless directory and its contents

---------

Co-authored-by: Benjamin Ironside Goldstein <[email protected]>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
nastasha-solomon pushed a commit that referenced this pull request Dec 19, 2024
@mergify @benironside @github-actions
[8.x] BYO LLM Image Update (backport #6368) (#6378)
d6c2d3e 
* BYO LLM Image Update (#6368)

* BYO LLM Image Update

* incorporates Janeen's review

(cherry picked from commit f8eb92a)

# Conflicts:
#	docs/serverless/AI-for-security/connect-to-byo-llm.asciidoc
#	docs/serverless/AI-for-security/images/lms-studio-model-loaded-msg.png

* Delete docs/serverless directory and its contents

---------

Co-authored-by: Benjamin Ironside Goldstein <[email protected]>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nastasha-solomon nastasha-solomon nastasha-solomon approved these changes

@jmikell821 jmikell821 jmikell821 left review comments

Assignees

@benironside benironside

Labels
v8.16.0 v8.17.0 v8.18.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Request] Update Docs for Connecting Local LLM
3 participants
@benironside @jmikell821 @nastasha-solomon