Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jenkins cleanup #742

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Jenkins cleanup #742

wants to merge 6 commits into from

Conversation

nkammah
Copy link
Contributor

@nkammah nkammah commented Nov 21, 2023

Description

This PR should be merged after #740 and #741 have been merged and running in parallel to the Jenkins jobs for a while and we're confident in the Buildkite setup.

The secrets in the prod vault stored at secret/devops-ci/terraform-provider-ec should also be wiped-out post migration.

Related Issues

Motivation and Context

How Has This Been Tested?

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (improves code quality but has no user-facing effect)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation

Readiness Checklist

  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

@nkammah nkammah requested a review from a team as a code owner November 21, 2023 11:21
@nkammah nkammah requested review from tobio and dimuon November 21, 2023 11:21
@nkammah nkammah mentioned this pull request Nov 21, 2023
Open
tobio
tobio approved these changes Nov 22, 2023
View reviewed changes
Copy link
Member

@tobio tobio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobio tobio tobio approved these changes

@dimuon dimuon Awaiting requested review from dimuon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nkammah @tobio