Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confirm out_time_ms is a number #1771

Merged
merged 1 commit into from
Aug 24, 2023

Conversation

BrandonHalig
Copy link
Contributor

@BrandonHalig BrandonHalig commented Aug 1, 2023

Description

In get_latest_ms_progress(), the value of out_time_ms can equal 'N/A\n', this code will prevent a ValueError when dividing a string by a number. Since this is only a progress indicator, it should not crash the program.

Issue Fixes

Prevents a ValueError when dividing a string by a number

Checklist:

  • I am pushing changes to the develop branch
  • I am using the recommended development environment
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have formatted and linted my code using python-black and pylint
  • I have cleaned up unnecessary files
  • My changes generate no new warnings
  • My changes follow the existing code-style
  • My changes are relevant to the project

Any other information (e.g how to test the changes)

None

In get_latest_ms_progress(), the value of out_time_ms can equal 'N/A\n', this code confirms this will not be the case in the future. Since this is only a progress indicator, it should not crash the program.
@OpenSourceSimon OpenSourceSimon added bug fix Pull request that adds a bug fix before next release Issue must be solved / PR must be merged before next release keep labels Aug 1, 2023
@OpenSourceSimon OpenSourceSimon self-assigned this Aug 1, 2023
@github-actions github-actions bot added stale and removed stale labels Aug 8, 2023
@github-actions github-actions bot added stale and removed stale labels Aug 22, 2023
@OpenSourceSimon OpenSourceSimon merged commit cce9320 into elebumm:develop Aug 24, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
before next release Issue must be solved / PR must be merged before next release bug fix Pull request that adds a bug fix keep
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants