Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pgvector support #10

Open
wants to merge 2 commits into
base: wasm
Choose a base branch
from
Open

Conversation

e253
Copy link

@e253 e253 commented Jun 6, 2024

Adds necessary changes for electric-sql/pglite#95.

@pmp-p
Copy link

pmp-p commented Jun 7, 2024

Thanks for the contribution ! Though it may not be necessary to use static loading anymore : we are currently working on loading shared extensions in pg 16.2. Keeping this open until shared vector has been tested and we will get back to you.

@pmp-p pmp-p self-assigned this Jun 7, 2024
@AntonOfTheWoods
Copy link

@pmp-p , @samwillis , I guess that is the disadvantage of creating new non-public repos and working there... Community contributions that will likely never get used.

@pmp-p
Copy link

pmp-p commented Jun 7, 2024

@AntonOfTheWoods that contribution is suitable for a wasi build and maybe later native retargeting. The problem is more pg not accepting github PR, adding wasm support + dlopen is unlikely to be a small patch to upstream in the mail :( . And same the other way around, though patchwork is ready it is not a format suitable for github contributions So we still have to think an efficient way that will fit both.

I think leaving open PR against a pg git fork are the way to go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants