fix: windows signature verification special chars #8409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
by applying electron-userland#8051 and noted in electron-userland#8162 win signature verification of signatures created using certificates including special chars like german umlauts got broken in electron-updater >= 1.6.9 issue at hand is that the windows set command does not terminate when reading semicolon; setting %PATH% is a good example for this c.f. https://learn.microsoft.com/en-us/previous-versions/windows/it-pro/windows-xp/bb490998(v=technet.10) so instead commands should be concatenated using & Closes electron-userland#8162
🦋 Changeset detectedLatest commit: d04b0b5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for car-park-attendant-cleat-11576 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
This was referenced Aug 11, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
by applying #8051 and noted in #8162 win signature verification of signatures created using
certificates including special chars like german
umlauts got broken in electron-updater >= 1.6.9
issue at hand is that the windows set command does not terminate when reading semicolon;
setting %PATH% is a good example for this
c.f. https://learn.microsoft.com/en-us/previous-versions/windows/it-pro/windows-xp/bb490998(v=technet.10) so instead commands should be concatenated using &
Closes #8162