fix: electron-builder fails when list of node_modules files is too big to pass in a glob

.changeset/khaki-buckets-jog.md

@@ -0,0 +1,5 @@
+---
+"app-builder-lib": patch
+---
+
+fix: electron-builder fails when list of node_modules files is too big to pass in a glob

packages/app-builder-lib/src/asar/asarUtil.ts

@@ -87,10 +87,10 @@ export class AsarPackager {
     const links: Array<Link> = []
     const symlinkType = platform() === "win32" ? "junction" : "file"
 
-    const matchUnpacker = (file: string, dest: string, stat: fs.Stats) => {
+    const matchUnpacker = (file: string, dest: string, stat: fs.Stats, tmpUnpackedPaths: Set<string>) => {
       if (this.config.unpackPattern?.(file, stat)) {
         log.debug({ file }, "unpacking")
-        unpackedPaths.add(dest)
+        tmpUnpackedPaths.add(`**${path.sep}${dest}`)
         return
       }
     }
@@ -145,6 +145,7 @@ export class AsarPackager {
       }
 
       // Don't use BluebirdPromise, we need to retain order of execution/iteration through the ordered fileset
+      const tmpUnpackedPaths = new Set<string>()
       for (let i = 0; i < fileSet.files.length; i++) {
         const file = fileSet.files[i]
         const transformedData = fileSet.transformedFiles?.get(i)
@@ -153,13 +154,23 @@ export class AsarPackager {
         const relative = path.relative(this.config.defaultDestination, getDestinationPath(file, fileSet))
         const destination = path.resolve(this.rootForAppFilesWithoutAsar, relative)
 
-        matchUnpacker(file, destination, stat)
+        matchUnpacker(file, relative, stat, tmpUnpackedPaths)
         taskManager.addTask(writeFileOrProcessSymlink({ transformedData, file, destination, stat, fileSet }))
 
         if (taskManager.tasks.length > MAX_FILE_REQUESTS) {
           await taskManager.awaitTasks()
         }
       }
+
+      if (tmpUnpackedPaths.size === fileSet.files.length) {
+        const relative = path.relative(this.config.defaultDestination, fileSet.destination)
+        unpackedPaths.add(`**${path.sep}${relative}${path.sep}**`)
+      } else {
+        // add all tmpUnpackedPaths to unpackedPaths
+        for (const it of tmpUnpackedPaths) {
+          unpackedPaths.add(it)
+        }
+      }
     }
     // finish copy then set up all symlinks
     await taskManager.awaitTasks()

packages/app-builder-lib/src/targets/nsis/NsisTarget.ts

@@ -142,7 +142,7 @@ export class NsisTarget extends Target {
     const setupText = this.isPortable ? "" : "Setup "
     const archSuffix = !this.shouldBuildUniversalInstaller && primaryArch != null ? getArchSuffix(primaryArch, defaultArch) : ""
 
-    return "${productName} " + setupText + "${version}" + archSuffix + ".${ext}";
+    return "${productName} " + setupText + "${version}" + archSuffix + ".${ext}"
   }
 
   private get isPortable(): boolean {