feat: require Node 16.20.0

electron · Mar 7, 2024 · 6aa6a9a · 6aa6a9a
1 parent d875b26
commit 6aa6a9a
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 5 deletions.
diff --git a/.circleci/config.yml b/.circleci/config.yml
@@ -15,7 +15,7 @@ workflows:
                 condition:
                   and:
                     - equal: [ node/macos, << matrix.executor >> ]
-                    - equal: [ '14.16', << matrix.node-version >> ]
+                    - equal: [ '16.20', << matrix.node-version >> ]
                 steps:
                   - node/install-rosetta
             - when:
@@ -37,8 +37,6 @@ workflows:
                 - '20.9'
                 - '18.17'
                 - '16.20'
-                # Stay below 14.17.0 or nvm tries to download arm64 artifacts which don't exist
-                - '14.16'
       - cfa/release:
           requires:
             - test

diff --git a/lib/crawlfs.js b/lib/crawlfs.js
@@ -16,7 +16,7 @@ async function determineFileType (filename) {
 
 module.exports = async function (dir, options) {
   const metadata = {}
-  let crawled = await glob(dir, options || {})
+  let crawled = await glob(dir, options ?? {})
 
   // https://github.com/isaacs/node-glob/issues/576
   crawled = crawled.sort((a, b) => a.localeCompare(b, 'en'))

diff --git a/package.json b/package.json
@@ -13,7 +13,7 @@
     "lib/index.d.ts"
   ],
   "engines": {
-    "node": ">=10.12.0"
+    "node": ">=16.20"
   },
   "license": "MIT",
   "homepage": "https://github.com/electron/asar",