Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: better error message when extracting a file that doesn't exist in the archive #286

Merged
merged 1 commit into from
Nov 7, 2023
Merged

fix: better error message when extracting a file that doesn't exist in the archive #286

merged 1 commit into from
Nov 7, 2023

Conversation

erikian
Copy link
Member

@erikian erikian commented Oct 21, 2023

Fixes #230

@erikian erikian requested a review from a team as a code owner October 21, 2023 19:04
BlackHole1
BlackHole1 approved these changes Oct 22, 2023
View reviewed changes
Copy link
Member

@BlackHole1 BlackHole1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@erickzhao erickzhao merged commit b9f5c8a into main Nov 7, 2023
3 checks passed
@erickzhao erickzhao deleted the fix/err-file-not-found-in-asar branch November 7, 2023 21:30
@continuous-auth Continuous Auth
Copy link

🎉 This PR is included in version 3.2.8 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erickzhao erickzhao erickzhao approved these changes

@BlackHole1 BlackHole1 BlackHole1 approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

error
3 participants
@erikian @BlackHole1 @erickzhao